Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hybrid Approach #99

Merged
merged 13 commits into from
Feb 20, 2020
Merged

Hybrid Approach #99

merged 13 commits into from
Feb 20, 2020

Conversation

dhhyi
Copy link
Collaborator

@dhhyi dhhyi commented Jan 27, 2020

PR Type

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no API changes)
[x] Build-related changes
[x] CI-related changes
[ ] Documentation content changes
[x] Application / infrastructure changes
[ ] Other:

What Is the New Behavior?

see Project and Wiki

  • All prerequisites for running ICM and PWA in hybrid mode are handled:
    • everything HTTPS
    • URL rewriting on ICM is considered
    • PWA URL rewriting is considered
    • necessary refactorings
  • example mappings for URLs between both
  • TODO: documentation, waiting for insert PR here

Out of scope for this PR

Does this PR Introduce a Breaking Change?

[ ] Yes
[x] No

@dhhyi dhhyi added the feature New feature or request label Jan 27, 2020
@dhhyi dhhyi self-assigned this Jan 27, 2020
@dhhyi dhhyi changed the title Feature/hybrid approach feat: Hybrid Approach Jan 27, 2020
@dhhyi dhhyi force-pushed the feature/hybrid_approach branch 7 times, most recently from efb095e to 68f0c49 Compare January 31, 2020 15:04
@dhhyi dhhyi force-pushed the feature/hybrid_approach branch 8 times, most recently from 88a80d1 to 4fb0862 Compare February 10, 2020 15:53
@dhhyi dhhyi force-pushed the feature/hybrid_approach branch 3 times, most recently from 9725eb5 to b1b71cb Compare February 10, 2020 18:03
@dhhyi dhhyi changed the title feat: Hybrid Approach Hybrid Approach Feb 10, 2020
@dhhyi dhhyi marked this pull request as ready for review February 10, 2020 19:43
@dhhyi dhhyi added this to the 0.18 milestone Feb 10, 2020
dhhyi added a commit that referenced this pull request Feb 12, 2020
dhhyi added a commit that referenced this pull request Feb 12, 2020
dhhyi added a commit that referenced this pull request Feb 12, 2020
server.ts Show resolved Hide resolved
@dhhyi dhhyi merged commit 7cfb066 into develop Feb 20, 2020
dhhyi added a commit that referenced this pull request Feb 20, 2020
dhhyi added a commit that referenced this pull request Feb 20, 2020
@dhhyi dhhyi deleted the feature/hybrid_approach branch February 20, 2020 10:31
dhhyi added a commit that referenced this pull request Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants