-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare for 1.2.0 release #790
Prepare for 1.2.0 release #790
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but maybe we need to wait until the issue reported today about not working with Insiders gets resolved. 1.63 started endgame yesterday and is likely to ship a week on Thursday.
@gjsjohnmurray Yes, I think we need to wait until that issue is resolved |
I propose we renumber this to 1.2. One reason is that #782 (github.dev and vscode.dev support) is a significant step. Another is I'd like us to be ready to use the upcoming extension pre-release mechanism (see microsoft/vscode#138068). It's already working in 1.63 Insiders, which is now in endgame and expected to release next Thursday. The recommended version numbering pattern for the pre-release mechanism is to use EVEN numbers in the minor position for the regular releases and ODD for pre-releases, so it'd be good to get the extension onto an even minor (2) soon. Also pinging @isc-rsingh for an opinion on this. |
I agree with 1.2.0 |
@gjsjohnmurray Would it be possible to upload our beta versions in the pre-release stream using the current "-beta.X" suffix? If so, I think we should just modify that action to have a publish step and keep everything else as-is. |
Marketplace at the moment allows only three parts, major.minor.patch |
I see you are already looking into this, you can check out the docs which are work in progress and will be ready tomorrow |
An alternative strategy would be to use YYYYMMDDNN as the patch digit for pre-releases. This format means it's easier to differentiate pre-releases from regular ones, and to see at a glance how recent a particular pre-release is. The NN part gives scope for up to 99 pre-releases in a single day, which should be more than enough! |
@gjsjohnmurray @daimor Can you add the CI changes to this PR or should we open another one for that? |
I'll do it later, with a separate PR |
@daimor I will wait for the CI updates to be decided upon before I update and merge this PR because I will likely have to make README changes |
I also agree with calling this 1.2 and all your reasoning behind it @gjsjohnmurray |
No description provided.