Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull event handler should skip actioning unmapped files #453

Closed
isc-tleavitt opened this issue Aug 2, 2024 · 3 comments · Fixed by #476
Closed

Pull event handler should skip actioning unmapped files #453

isc-tleavitt opened this issue Aug 2, 2024 · 3 comments · Fixed by #476
Assignees
Labels
bug Something isn't working customer Based on customer feedback (as opposed to something identified by developers)

Comments

@isc-tleavitt
Copy link
Collaborator

e.g., things that are in the repo for safekeeping but not actually source controlled - the risk is that stray things in the repo could be imported and overwrite changes that are not reflected in the repo automatically

@isc-tleavitt isc-tleavitt added bug Something isn't working customer Based on customer feedback (as opposed to something identified by developers) labels Aug 2, 2024
@isc-tleavitt isc-tleavitt added this to the Summer 2024 Improvements milestone Aug 2, 2024
@isc-tleavitt isc-tleavitt self-assigned this Aug 30, 2024
@isc-tleavitt
Copy link
Collaborator Author

This is a common use case in HCC for e.g. System Default Settings, which are present in all branches but in a branch-specific folder.

@isc-tleavitt
Copy link
Collaborator Author

The error here is actually that we'd hit a error trying to add a new unmapped file to the source control file tracking global.

@isc-tleavitt
Copy link
Collaborator Author

(looking at better logging and trying to run a bunch of edge cases for #467 this popped out with a bit more clarity.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working customer Based on customer feedback (as opposed to something identified by developers)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant