Fixed checking out non-existent branch #557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #557 +/- ##
==========================================
- Coverage 25.16% 25.06% -0.10%
==========================================
Files 18 18
Lines 2647 2657 +10
==========================================
Hits 666 666
- Misses 1981 1991 +10 ☔ View full report in Codecov by Sentry. |
isc-tleavitt
requested changes
Oct 22, 2024
Should only fail when the error stream contains an error message
|
I linked #539 since it was related and a quick addition to the current change. Now behavior is that checking out remote or local branches succeed unless they don't exist or you have uncommitted changes that will be deleted. In both cases the errors are fairly descriptive. |
isc-tleavitt
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #549, #539
@isc-tleavitt Right now this throws an error (so that user is aware that checkout failed). Is there a better way to show an alert on the management portal / vscode / studio? (This happens on "AfterUserAction" so we have no access to the "Target" functionality of %Studio.SourceControl.Base.