feat: support localePattern option for locale structured with directory
#270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ota-meshi
approved these changes
Nov 18, 2021
lib/types/settings.ts
Outdated
| * You need to use the locale capture as a named capture `?<locale>`, so it’s be able to capture from the path of the locale resources. | ||
| * If you omit it, it will be captured from the resource path with the same regular expression pattern as `vue-cli-plugin-i18n`. | ||
| */ | ||
| localePattern?: RegExp |
There was a problem hiding this comment.
Regular expressions cannot be serialized to JSON, so users can only use .eslintrc.js style configurations. Could you change it to accept string | RegExp?
There was a problem hiding this comment.
Oh, Indeed 😅
we have to support cases in other formats but .eslintrc.js, such as .eslintrc.yaml.
ota-meshi
requested changes
Nov 18, 2021
|
I've just fixed it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.