Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix false positives of key used in <i18n> component in no-unused-keys rule. #92

Merged
merged 2 commits into from
Aug 5, 2020
Merged

Fix false positives of key used in <i18n> component in no-unused-keys rule. #92

merged 2 commits into from
Aug 5, 2020

Conversation

ota-meshi
Copy link
Member

@ota-meshi ota-meshi commented Aug 5, 2020 •
edited
Loading

fixes #90

This PR also supports the <i18n-t> component.
refs #91, #93

@ota-meshi ota-meshi added the Type: Bug Bug or Bug fixes label Aug 5, 2020
kazupon
kazupon approved these changes Aug 5, 2020
View reviewed changes
Copy link
Member

@kazupon kazupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@kazupon kazupon merged commit 252d125 into master Aug 5, 2020
@kazupon kazupon deleted the issue90 branch August 5, 2020 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kazupon kazupon kazupon approved these changes

Assignees
No one assigned
Labels
Type: Bug Bug or Bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

no-message-keys warns when using <i18n> components and <i18n> blocks.
2 participants
@ota-meshi @kazupon