Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: provide URL encoded paths in RouteLocation #76

Merged
merged 4 commits into from
Oct 23, 2023
Merged

fix: provide URL encoded paths in RouteLocation #76

merged 4 commits into from
Oct 23, 2023

Conversation

Achneoder
Copy link
Contributor

@Achneoder Achneoder commented Oct 19, 2023

Description

Updates fullPath, path and href of resolved routes to be properly URL encoded.

Additional context

As @kazupon suggested in nuxt-modules/i18n#2495 here's a fix for not properly encoded paths.

@kazupon kazupon added the bug Includes new features label Oct 19, 2023
Copy link
Member

@kazupon kazupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!
Your PR look good to me.

But, Your PR has e2e issue.
I hope you will fix it.

Achneoder and others added 2 commits October 22, 2023 10:20
Co-authored-by: Bobbie Goede <bobbiegoede@gmail.com>
@kazupon
Copy link
Member

kazupon commented Oct 22, 2023

@Achneoder
This PR still has lint error.
You are almost there before your contribution is merged!

@kazupon kazupon merged commit 13e647f into intlify:main Oct 23, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Includes new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants