Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a comment about pluralRules to the code in pluralization docs #1873

Merged
merged 1 commit into from
Jul 15, 2024
Merged

Added a comment about pluralRules to the code in pluralization docs #1873

merged 1 commit into from
Jul 15, 2024

Conversation

M1h4n1k
Copy link
Contributor

@M1h4n1k M1h4n1k commented Jun 13, 2024

I removed meaningless comment and replaced it with more useful comment about pluralRules for Composition api.
If the code is understandable I am just copying it and I'm not really reading through the documentation, and seems like many people do it the same way. However, in the docs there is a very important note. So, there is a higher chance that people will notice it if it's put directly into the code.

I've actually done the same mistake in 2 different projects. Luckily, at the second time I remembered that there was something wrong with docs and it didn't take me very long, but at the first time I spent quite a lot of time

@M1h4n1k M1h4n1k changed the title Added a comment about pluralRules to the code pluralization docs Added a comment about pluralRules to the code in pluralization docs Jun 13, 2024
Copy link
Member

@kazupon kazupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, my late response
We appreciate your PR!
Thank you !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Documentation A documetation fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants