Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: vue-i18n type definition for vue package #1888

Merged
merged 1 commit into from
Jul 14, 2024
Merged

fix: vue-i18n type definition for vue package #1888

merged 1 commit into from
Jul 14, 2024
+3 −3

Conversation

kazupon
Copy link
Member

@kazupon kazupon commented Jul 14, 2024

No description provided.

@kazupon kazupon added the Type: Improvement Includes backwards-compatible fixes label Jul 14, 2024
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

Deploying vue-i18n-next with  Cloudflare Pages  Cloudflare Pages

Latest commit: d38633f
Status: ✅  Deploy successful!
Preview URL: https://48929470.vue-i18n-next.pages.dev
Branch Preview URL: https://fix-vue-type-definition-exte.vue-i18n-next.pages.dev

View logs

@kazupon kazupon merged commit c18144d into master Jul 14, 2024
25 checks passed
@kazupon kazupon deleted the fix/vue-type-definition-extending branch July 14, 2024 08:41
@romansp romansp mentioned this pull request Aug 9, 2024
Closed
@kazupon kazupon mentioned this pull request Aug 13, 2024
Closed
4 tasks
@BobbieGoede
Copy link
Member

I think we will need a patch release for v9 to also change the type augmentations to use 'vue' 😥 (relevant nuxt/nuxt#28542)

Due to Vue Router changing its augmentation, Nuxt is doing so too, mixed augmentation will break projects with v9.

@danielroe danielroe mentioned this pull request Aug 16, 2024
Merged
BobbieGoede pushed a commit to BobbieGoede/vue-i18n-next that referenced this pull request Aug 16, 2024
@kazupon @BobbieGoede
fix: vue-i18n type definition for vue package (intlify#1888)
f6bf148
@BobbieGoede
Copy link
Member

@kazupon
I've created a v9 branch based on e37cba0 which includes this change as well as c07fbe3 here https://github.com/BobbieGoede/vue-i18n-next/tree/v9

@kazupon
Copy link
Member Author

kazupon commented Aug 16, 2024

@BobbieGoede
Thanks!
I've made v9 branch in vue-i18n.

You can open the PR on it!

@BobbieGoede BobbieGoede mentioned this pull request Aug 16, 2024
Merged
kazupon added a commit that referenced this pull request Aug 16, 2024
@BobbieGoede @kazupon
fix: vue-i18n type definition for vue package (#1919)
b07a9a4 
* fix: vue-i18n type definition for vue package (#1888)

* fix: vue-i18n-bridge type definition for vue package

---------

Co-authored-by: kazuya kawaguchi <kawakazu80@gmail.com>
@hinogi
Copy link
Contributor

hinogi commented Oct 1, 2024

problem persists with v10.0.0 and vue 3.5

@BobbieGoede
Copy link
Member

@hinogi
Can you open a new issue and provide a minimal reproduction? 🙏

@hinogi
Copy link
Contributor

hinogi commented Oct 1, 2024

I guess I am unable to do that. But I use Quasar and vite and I get TS2339 Property $t does not exist on type 'CreateComponentPublicInstanceWithMixins<ToResolvedProps<__VLS_PublicProps, { "update:modelValue": (modelValue: string) => any }>...>

@riderx riderx mentioned this pull request Oct 4, 2024
Closed
@nerds-github nerds-github mentioned this pull request Oct 26, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Type: Improvement Includes backwards-compatible fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kazupon @BobbieGoede @hinogi