Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breaking: drop $tc and tc #2017

Merged
merged 3 commits into from
Nov 16, 2024
Merged

breaking: drop $tc and tc #2017

merged 3 commits into from
Nov 16, 2024

Conversation

kazupon
Copy link
Member

@kazupon kazupon commented Nov 15, 2024

breaking changes

Translate pluralization API $tc and tc were deprecated in v10.
The code that has interface and warning was left in place, we remove completely in v11, as it is no longer needed.

@kazupon kazupon added the Type: Breaking Includes backwards-incompatible fixes label Nov 15, 2024
Copy link

cloudflare-workers-and-pages bot commented Nov 15, 2024

Deploying vue-i18n-next with  Cloudflare Pages  Cloudflare Pages

Latest commit: bff5ba0
Status: ✅  Deploy successful!
Preview URL: https://79012e94.vue-i18n-next.pages.dev
Branch Preview URL: https://breaking-drop-tc.vue-i18n-next.pages.dev

View logs

Copy link

pkg-pr-new bot commented Nov 15, 2024

Open in Stackblitz

@intlify/core

pnpm add https://pkg.pr.new/@intlify/core@2017

@intlify/devtools-types

pnpm add https://pkg.pr.new/@intlify/devtools-types@2017

@intlify/core-base

pnpm add https://pkg.pr.new/@intlify/core-base@2017

petite-vue-i18n

pnpm add https://pkg.pr.new/petite-vue-i18n@2017

@intlify/message-compiler

pnpm add https://pkg.pr.new/@intlify/message-compiler@2017

@intlify/shared

pnpm add https://pkg.pr.new/@intlify/shared@2017

vue-i18n

pnpm add https://pkg.pr.new/vue-i18n@2017

@intlify/vue-i18n-core

pnpm add https://pkg.pr.new/@intlify/vue-i18n-core@2017

commit: bff5ba0

@kazupon kazupon requested a review from BobbieGoede November 15, 2024 03:48
Copy link
Member

@BobbieGoede BobbieGoede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

We should add a breaking changes page for v11 that mentions the full removal of the deprecated features, I forgot to mention it in the previous PR 😅

While checking for the occurrence of $tc and tc I noticed there's outdated Japanese documentation in docs/.ja, are these still being used some place? If not, we could clean it up in a separate change.

@kazupon
Copy link
Member Author

kazupon commented Nov 16, 2024

We should add a breaking changes page for v11 that mentions the full removal of the deprecated features, I forgot to mention it in the previous PR 😅

Oops.
I forgot it. 😓
I've just added docs
6c8c9a3

@kazupon kazupon merged commit 3882d02 into master Nov 16, 2024
26 checks passed
@kazupon kazupon deleted the breaking/drop-tc branch November 16, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Breaking Includes backwards-incompatible fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants