PyAutoGUI controller #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
This pull request introduces 1 alert when merging 8a98505 into 4090679 - view on LGTM.com new alerts:
|
Codecov Report
@@ Coverage Diff @@
## master #21 +/- ##
==========================================
+ Coverage 80.21% 85.25% +5.03%
==========================================
Files 16 17 +1
Lines 4387 4400 +13
==========================================
+ Hits 3519 3751 +232
+ Misses 868 649 -219
Continue to review full report at Codecov.
|
pevogam
force-pushed
the
pyautogui-controller
branch
from
8a98505 to
932d057
Compare
|
This pull request introduces 1 alert when merging 932d057 into dd17e65 - view on LGTM.com new alerts:
|
pevogam
force-pushed
the
pyautogui-controller
branch
14 times, most recently
from
65bd61e to
41b56f1
Compare
This includes dropping the platform-specific "desktop" in favor of the more platform-generic "display" for the DC backends as we could technically manipulate Android or other devices.
The controllers hierarchy taxonomy is now more readable and clearer, also in better accordance with the finder class hierarchy.
This requires also adding the necessary input (key, modifier, and mouse button) maps for the backend, in this case keyword strings.
The region tests that were the only ones doing this before only tested the default backend thus leaving a big gap in covering the alternatives that we compensate for here.
The default number of clicks should be one corresponding to a single click and writing unit tests for all backends revealed it wasn't so for some backends until now.
pevogam
force-pushed
the
pyautogui-controller
branch
from
41b56f1 to
b87396d
Compare
This and the lack fo setting the base attribute was all discovered from the new unit tests.
Some methods with modifier args used a default None while others were still requiring the argument to be explicitly set, even if again to None.
It is simpler to just require a NOOP sync instead of requiring it for some backends and not for others, thus confusing the users and requiring them to know internal behaviors.
This is now done for all unit tests.
The following subbranch completes the unit test coverage undertaking from all recent branches by adding a final set of base unit tests for the display controllers.
An issue has been reported as the scrot support on Fedora is significantly lacking.
These coordinates are using during mouse initialization and are currently considered eligible.
This controller contains additional dependencies we haven't fully handled, hasn't been thoroughly tested, and is even unfinished, but contains valuable code that could be an example for how to derive a custom controller backend.
pevogam
force-pushed
the
pyautogui-controller
branch
from
b87396d to
908ff41
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add PyAutoGUI screen controller refactoring current controller state