Fix Hashie::Dash Defaults #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This also addresses #53 |
| else | ||
| begin | ||
| value.dup | ||
| rescue TypeError |
There was a problem hiding this comment.
What objects throw TypeError when they're duped?
There was a problem hiding this comment.
According to the Rails docs, the non-duplicable objects are: nil, false, true, symbols, numbers, class objects and module objects.
|
👍 looks good to me. |
|
I've had a change of heart over the last few weeks over handling the Numeric case. If conciseness is desired, doing the minimal version is probably just as good: |
|
Thanks @ohrite for the pull! I'm helping clean up issues and pulls and got commit access. If you don't mind, could you update your pull to use the concise version you described in the comment above? |
Previously, a Hashie::Dash's property's :default value was used by all instantiations. This change calls .dup on all non-Numeric default values during instantiation, rescuing from TypeError.
|
@jch updated to the concise version and ready to rock! |
|
Thanks! 🍻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, a Hashie::Dash's property's :default value was used by all instantiations.
This change calls .dup on all non-Numeric default values during instantiation, rescuing from TypeError.