-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mlynarchik Artyom #40
Open
Archeex
wants to merge
36
commits into
introduction-to-python-bsuir-2019:master
Choose a base branch
from
Archeex:final_task
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Mlynarchik Artyom #40
Archeex
wants to merge
36
commits into
introduction-to-python-bsuir-2019:master
from
Archeex:final_task
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexeiBuzuma
added
the
[Deadline] Iteration 1-2
This is a marker for first and second iterations deadline.
label
Nov 17, 2019
AlexeiBuzuma
reviewed
Dec 1, 2019
AlexeiBuzuma
removed
Hard Deadline
[Deadline] Iteration 1-2
This is a marker for first and second iterations deadline.
labels
Dec 12, 2019
Моменты, которые можно улучшить:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For install: pip install . -r requirements.txt
Small imperfection: file with font should be locate in directory from which launch module.
Codestyle checked with
pycodestyle
.Module
date_validation
is redundant, i know :)Unfortunately I didnt have time to fix saving 'JPG' images to PDF-file (only 'PNG' working, because i choose bad module).
5/6 iterations completed.