Skip to content

Conversation

igdianov
Copy link
Collaborator

Fixes #273

@codecov
Copy link

codecov bot commented Jun 22, 2020

Codecov Report

Merging #275 into master will increase coverage by 0.00%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #275   +/-   ##
=========================================
  Coverage     74.02%   74.02%           
  Complexity     1070     1070           
=========================================
  Files            72       72           
  Lines          4750     4754    +4     
  Branches        679      680    +1     
=========================================
+ Hits           3516     3519    +3     
  Misses          934      934           
- Partials        300      301    +1     
Impacted Files Coverage Δ Complexity Δ
.../jpa/query/schema/impl/GraphQLJpaQueryFactory.java 78.89% <83.33%> (-0.02%) 229.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 978d9d0...1243b0b. Read the comment docs.

@igdianov igdianov force-pushed the fix-GH-273-entity-caching-regression branch from 29f46bc to ac5bc1c Compare June 23, 2020 01:44
@hump
Copy link

hump commented Jun 24, 2020

look good, no caching effect with this PR.
Tested with graphql-jpa-query-example-simple:
query with graphiql:

{
  Humans {
    select {
      name
    }
  }
}

Result:

{
  "data": {
    "Humans": {
      "select": [
        {
          "name": "Luke Skywalker"
        },
        {
          "name": "Darth Vader"
        },
        {
          "name": "Han Solo"
        },
        {
          "name": "Leia Organa"
        },
        {
          "name": "Wilhuff Tarkin"
        }
      ]
    }
  }
}

change name with h2-console
image

Result:

{
  "data": {
    "Humans": {
      "select": [
        {
          "name": "Luky Skywalker"
        },
        {
          "name": "Darth Vader"
        },
        {
          "name": "Han Solo"
        },
        {
          "name": "Leia Organa"
        },
        {
          "name": "Wilhuff Tarkin"
        }
      ]
    }
  }
}```

@hump
Copy link

hump commented Jun 24, 2020

But - Caching effect remains for this query (single record with id):

{
  Human(id: "1000") {
    name
  }
}

@igdianov igdianov force-pushed the fix-GH-273-entity-caching-regression branch from b1ca2bf to 93d2b85 Compare June 27, 2020 01:12
@igdianov igdianov changed the title fix(GH-273): add detach entity in result list stream fix(GH-273): detach result entities from entity manager persistent context Jun 27, 2020
@igdianov igdianov merged commit a678b57 into master Jun 27, 2020
@igdianov igdianov deleted the fix-GH-273-entity-caching-regression branch June 27, 2020 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release 0.4.10 introduces caching effect
2 participants