Skip to content

chore(deps): bump spring-boot.version from 3.2.2 to 3.2.3 #456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 10, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,6 +1,12 @@
package com.introproventures.graphql.jpa.query.autoconfigure;

import static com.introproventures.graphql.jpa.query.schema.impl.BatchLoaderRegistry.getMappedBatchDataLoaderMap;

import graphql.GraphQL;
import java.util.Map;
import java.util.concurrent.CompletableFuture;
import org.dataloader.DataLoaderOptions;
import org.springframework.beans.factory.InitializingBean;
import org.springframework.beans.factory.ListableBeanFactory;
import org.springframework.boot.autoconfigure.AutoConfiguration;
import org.springframework.boot.autoconfigure.condition.ConditionalOnBean;
Expand All @@ -11,6 +17,7 @@
import org.springframework.graphql.ExecutionGraphQlService;
import org.springframework.graphql.execution.BatchLoaderRegistry;
import org.springframework.graphql.execution.GraphQlSource;
import reactor.core.publisher.Mono;

@AutoConfiguration(after = GraphQLJpaQueryGraphQlSourceAutoConfiguration.class)
@ConditionalOnClass({ GraphQL.class, GraphQlSource.class })
Expand All @@ -19,7 +26,18 @@
@Bean
@ConditionalOnMissingBean
BatchLoaderRegistry batchLoaderRegistry(ListableBeanFactory beanFactory) {
return new GraphQlAutoConfiguration(beanFactory).batchLoaderRegistry();
var batchLoaderRegistry = new GraphQlAutoConfiguration(beanFactory).batchLoaderRegistry();

DataLoaderOptions options = DataLoaderOptions.newOptions().setCachingEnabled(false);

batchLoaderRegistry
.forName(GraphQLJpaQueryGraphQlExecutionAutoConfiguration.class.getName())
.withOptions(options)
.registerMappedBatchLoader((keys, env) ->
Mono.fromCompletionStage(CompletableFuture.completedStage(Map.of()))

Check warning on line 37 in autoconfigure/src/main/java/com/introproventures/graphql/jpa/query/autoconfigure/GraphQLJpaQueryGraphQlExecutionAutoConfiguration.java

View check run for this annotation

Codecov / codecov/patch

autoconfigure/src/main/java/com/introproventures/graphql/jpa/query/autoconfigure/GraphQLJpaQueryGraphQlExecutionAutoConfiguration.java#L37

Added line #L37 was not covered by tests
);

return batchLoaderRegistry;
}

@Bean
Expand All @@ -32,4 +50,21 @@
) {
return new GraphQlAutoConfiguration(beanFactory).executionGraphQlService(graphQlSource, batchLoaderRegistry);
}

@Bean
InitializingBean batchLoaderRegistryConfigurer(BatchLoaderRegistry batchLoaderRegistry) {
return () -> {
DataLoaderOptions options = DataLoaderOptions.newOptions().setCachingEnabled(false);

getMappedBatchDataLoaderMap()
.forEach((name, mappedBatchLoader) ->
batchLoaderRegistry
.forName(name)
.withOptions(options)
.registerMappedBatchLoader((keys, env) ->
Mono.fromCompletionStage(mappedBatchLoader.load(keys, env))

Check warning on line 65 in autoconfigure/src/main/java/com/introproventures/graphql/jpa/query/autoconfigure/GraphQLJpaQueryGraphQlExecutionAutoConfiguration.java

View check run for this annotation

Codecov / codecov/patch

autoconfigure/src/main/java/com/introproventures/graphql/jpa/query/autoconfigure/GraphQLJpaQueryGraphQlExecutionAutoConfiguration.java#L65

Added line #L65 was not covered by tests
)
);
};
}
}
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
package com.introproventures.graphql.jpa.query.autoconfigure;

import static graphql.GraphQLContext.newContext;
import static graphql.annotations.AnnotationsSchemaCreator.newAnnotationsSchema;
import static graphql.schema.FieldCoordinates.coordinates;
import static graphql.schema.GraphQLCodeRegistry.newCodeRegistry;
Expand All @@ -9,6 +10,7 @@
import static graphql.schema.idl.RuntimeWiring.newRuntimeWiring;
import static java.util.Collections.emptyMap;
import static org.assertj.core.api.Assertions.assertThat;
import static org.dataloader.DataLoaderRegistry.newRegistry;
import static org.springframework.transaction.TransactionDefinition.PROPAGATION_REQUIRED;

import com.introproventures.graphql.jpa.query.autoconfigure.support.AdditionalGraphQLType;
Expand Down Expand Up @@ -58,6 +60,7 @@
import java.util.stream.Collectors;
import java.util.stream.Stream;
import org.assertj.core.api.InstanceOfAssertFactories;
import org.dataloader.DataLoaderRegistry;
import org.junit.jupiter.api.Test;
import org.reactivestreams.Publisher;
import org.reflections.Reflections;
Expand All @@ -69,6 +72,7 @@
import org.springframework.context.annotation.Bean;
import org.springframework.context.annotation.Configuration;
import org.springframework.core.io.Resource;
import org.springframework.graphql.execution.BatchLoaderRegistry;
import org.springframework.scheduling.concurrent.ThreadPoolTaskExecutor;
import org.springframework.stereotype.Component;
import org.springframework.transaction.TransactionDefinition;
Expand Down Expand Up @@ -101,6 +105,9 @@ public class GraphQLSchemaAutoConfigurationTest {
@Autowired
private GraphQLJpaQueryProperties graphQLJpaQueryProperties;

@Autowired
BatchLoaderRegistry batchLoaderRegistry;

@SpringBootApplication
@EnableGraphQLJpaQuerySchema(basePackageClasses = TestEntity.class)
static class Application {
Expand Down Expand Up @@ -520,4 +527,12 @@ void configuresSubscriptionTransactionalExecutionStrategyCustomizer() {
.isEqualTo(true);
});
}

@Test
void batchLoaderRegistry() {
DataLoaderRegistry dataLoaderRegistry = newRegistry().build();
batchLoaderRegistry.registerDataLoaders(dataLoaderRegistry, newContext().build());

assertThat(dataLoaderRegistry.getDataLoadersMap()).isNotEmpty().containsKeys("TestEntity.children");
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
package com.introproventures.graphql.jpa.query.autoconfigure.support;

import jakarta.persistence.Entity;
import jakarta.persistence.Id;
import lombok.Data;

@Entity
@Data
public class TestChildEntity {

@Id
String id;
}
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

import jakarta.persistence.Entity;
import jakarta.persistence.Id;
import jakarta.persistence.OneToMany;
import java.util.Set;
import lombok.Data;

@Entity
Expand All @@ -10,4 +12,7 @@ public class TestEntity {

@Id
private Long id;

@OneToMany
Set<TestChildEntity> children;
}
2 changes: 1 addition & 1 deletion dependencies/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
</description>

<properties>
<spring-boot.version>3.2.2</spring-boot.version>
<spring-boot.version>3.2.3</spring-boot.version>
<graphql-java.version>21.4</graphql-java.version>
<evo-inflector.version>1.3</evo-inflector.version>
<joda-time.version>2.12.7</joda-time.version>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,15 @@
mappedToOneBatchLoaders.putIfAbsent(batchLoaderKey, mappedBatchLoader);
}

public static Map<String, MappedBatchLoaderWithContext> getMappedBatchDataLoaderMap() {
var loaders = new LinkedHashMap<String, MappedBatchLoaderWithContext>();

Check warning on line 37 in schema/src/main/java/com/introproventures/graphql/jpa/query/schema/impl/BatchLoaderRegistry.java

View check run for this annotation

Codecov / codecov/patch

schema/src/main/java/com/introproventures/graphql/jpa/query/schema/impl/BatchLoaderRegistry.java#L37

Added line #L37 was not covered by tests

loaders.putAll(mappedToManyBatchLoaders);
loaders.putAll(mappedToOneBatchLoaders);

Check warning on line 40 in schema/src/main/java/com/introproventures/graphql/jpa/query/schema/impl/BatchLoaderRegistry.java

View check run for this annotation

Codecov / codecov/patch

schema/src/main/java/com/introproventures/graphql/jpa/query/schema/impl/BatchLoaderRegistry.java#L39-L40

Added lines #L39 - L40 were not covered by tests

return loaders;

Check warning on line 42 in schema/src/main/java/com/introproventures/graphql/jpa/query/schema/impl/BatchLoaderRegistry.java

View check run for this annotation

Codecov / codecov/patch

schema/src/main/java/com/introproventures/graphql/jpa/query/schema/impl/BatchLoaderRegistry.java#L42

Added line #L42 was not covered by tests
}

public static DataLoaderRegistry newDataLoaderRegistry(DataLoaderOptions dataLoaderOptions) {
DataLoaderRegistry dataLoaderRegistry = new DataLoaderRegistry();

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,6 @@ public void contextIsAutoConfigured() {
DataLoaderRegistry dataLoaderRegistry = newRegistry().build();
batchLoaderRegistry.registerDataLoaders(dataLoaderRegistry, newContext().build());

assertThat(dataLoaderRegistry.getDataLoadersMap()).isEmpty();
assertThat(dataLoaderRegistry.getDataLoadersMap()).isNotEmpty().containsKeys("Author.books", "Book.author");
}
}
Loading