Add test for test suite action util addTestToSuite #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimClarkson
added
hacktoberfest
Celeo
reviewed
Oct 18, 2019
|
@Celeo thanks for reviewing. I wasn't sure if I should be doing some cleanup in my tests (like resetting my mocks?) |
|
Sure, reset mocks if you need them for test-to-test assertions, i.e. asserting that a mock was called twice in test A, once in test B, never in test C, etc. If you don't need that functionality, then I don't think they need to be reset. |
Celeo
approved these changes
Oct 18, 2019
|
Sounds good, I think this PR is ready to merge then! I'll add some more tests over the coming days. |
|
Sounds good, thanks for the contribution! |
|
🚀 PR was released in v1.0.1 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing this pull request!
Please make the PR against the
masterbranch, add a description of what's changing, and link any relevant issues or PRs.Part of #5
What's changing
Added a test for the suites action addTestToSuite function
...
What else might be impacted?
...
Checklist
[x] Unit tests (updated and/or added)
[x] Documentation (function/class docs, comments, etc.)
Published PR with canary version:
1.0.1-canary.23.267.0