adding additional unit tests to duplicate modal and fixing context bi… #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Celeo
added
hacktoberfest
TimClarkson
approved these changes
Oct 21, 2019
|
🚀 PR was released in v1.0.1 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…nding
Thank you for contributing this pull request!
Please make the PR against the
masterbranch, add a description of what's changing, and link any relevant issues or PRs.adding ontop of issue #5
What's changing
additional unit tests to test the duplicate modal close functionality
What else might be impacted?
...
Checklist
[ ] Unit tests (updated and/or added)
[ ] Documentation (function/class docs, comments, etc.)
@Celeo there seems to be a context issue in duplicatemodal on save and cancel during testing which this PR should have addressed as well.
Published PR with canary version:
1.0.1-canary.24.317.0