Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase gitlog maximum buffer size to Infinity #1212

Merged

Conversation

whynotzoidberg
Copy link
Contributor

@whynotzoidberg whynotzoidberg commented May 13, 2020

What Changed

Increased gitlog maximum buffer size to Infinity

Why

The stdout maxBuffer exceeds when run on large projects.
See domharrington/node-gitlog#19 for further explanation.

📦 Published PR as canary version: under canary scope @auto-canary@9.32.1-canary.1212.15526.0

✨ Test out this PR locally via:

npm install @auto-canary/bot-list@9.32.1-canary.1212.15526.0
npm install @auto-canary/auto@9.32.1-canary.1212.15526.0
npm install @auto-canary/core@9.32.1-canary.1212.15526.0
npm install @auto-canary/all-contributors@9.32.1-canary.1212.15526.0
npm install @auto-canary/brew@9.32.1-canary.1212.15526.0
npm install @auto-canary/chrome@9.32.1-canary.1212.15526.0
npm install @auto-canary/cocoapods@9.32.1-canary.1212.15526.0
npm install @auto-canary/conventional-commits@9.32.1-canary.1212.15526.0
npm install @auto-canary/crates@9.32.1-canary.1212.15526.0
npm install @auto-canary/exec@9.32.1-canary.1212.15526.0
npm install @auto-canary/first-time-contributor@9.32.1-canary.1212.15526.0
npm install @auto-canary/gh-pages@9.32.1-canary.1212.15526.0
npm install @auto-canary/git-tag@9.32.1-canary.1212.15526.0
npm install @auto-canary/gradle@9.32.1-canary.1212.15526.0
npm install @auto-canary/jira@9.32.1-canary.1212.15526.0
npm install @auto-canary/maven@9.32.1-canary.1212.15526.0
npm install @auto-canary/npm@9.32.1-canary.1212.15526.0
npm install @auto-canary/omit-commits@9.32.1-canary.1212.15526.0
npm install @auto-canary/omit-release-notes@9.32.1-canary.1212.15526.0
npm install @auto-canary/released@9.32.1-canary.1212.15526.0
npm install @auto-canary/s3@9.32.1-canary.1212.15526.0
npm install @auto-canary/slack@9.32.1-canary.1212.15526.0
npm install @auto-canary/twitter@9.32.1-canary.1212.15526.0
npm install @auto-canary/upload-assets@9.32.1-canary.1212.15526.0
# or 
yarn add @auto-canary/bot-list@9.32.1-canary.1212.15526.0
yarn add @auto-canary/auto@9.32.1-canary.1212.15526.0
yarn add @auto-canary/core@9.32.1-canary.1212.15526.0
yarn add @auto-canary/all-contributors@9.32.1-canary.1212.15526.0
yarn add @auto-canary/brew@9.32.1-canary.1212.15526.0
yarn add @auto-canary/chrome@9.32.1-canary.1212.15526.0
yarn add @auto-canary/cocoapods@9.32.1-canary.1212.15526.0
yarn add @auto-canary/conventional-commits@9.32.1-canary.1212.15526.0
yarn add @auto-canary/crates@9.32.1-canary.1212.15526.0
yarn add @auto-canary/exec@9.32.1-canary.1212.15526.0
yarn add @auto-canary/first-time-contributor@9.32.1-canary.1212.15526.0
yarn add @auto-canary/gh-pages@9.32.1-canary.1212.15526.0
yarn add @auto-canary/git-tag@9.32.1-canary.1212.15526.0
yarn add @auto-canary/gradle@9.32.1-canary.1212.15526.0
yarn add @auto-canary/jira@9.32.1-canary.1212.15526.0
yarn add @auto-canary/maven@9.32.1-canary.1212.15526.0
yarn add @auto-canary/npm@9.32.1-canary.1212.15526.0
yarn add @auto-canary/omit-commits@9.32.1-canary.1212.15526.0
yarn add @auto-canary/omit-release-notes@9.32.1-canary.1212.15526.0
yarn add @auto-canary/released@9.32.1-canary.1212.15526.0
yarn add @auto-canary/s3@9.32.1-canary.1212.15526.0
yarn add @auto-canary/slack@9.32.1-canary.1212.15526.0
yarn add @auto-canary/twitter@9.32.1-canary.1212.15526.0
yarn add @auto-canary/upload-assets@9.32.1-canary.1212.15526.0

The stdout maxBuffer exceeds when run on large projects.
See domharrington/node-gitlog#19
for further explaination.
@codecov
Copy link

codecov bot commented May 13, 2020

Codecov Report

Merging #1212 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1212   +/-   ##
=======================================
  Coverage   80.86%   80.86%           
=======================================
  Files          54       54           
  Lines        3936     3936           
  Branches      847      847           
=======================================
  Hits         3183     3183           
  Misses        540      540           
  Partials      213      213           
Impacted Files Coverage Δ
packages/core/src/git.ts 88.02% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e50ede...bf35ee4. Read the comment docs.

@hipstersmoothie hipstersmoothie added the patch Increment the patch version when merged label May 15, 2020
@hipstersmoothie hipstersmoothie merged commit 1e2944f into intuit:master May 15, 2020
@adierkens
Copy link
Collaborator

🚀 PR was released in v9.32.1 🚀

@adierkens adierkens added the released This issue/pull request has been released. label May 15, 2020
@whynotzoidberg whynotzoidberg deleted the increase-gitlog-buffer-size branch May 25, 2020 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants