Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix automated old branch creation #1278

Merged
merged 1 commit into from
Jun 5, 2020
Merged

fix automated old branch creation #1278

merged 1 commit into from
Jun 5, 2020

Conversation

hipstersmoothie
Copy link
Collaborator

@hipstersmoothie hipstersmoothie commented Jun 5, 2020

What Changed

Fix branch creation for old majors

Why

closes #1270

Todo:

  • Add tests
📦 Published PR as canary version: under canary scope @auto-canary@9.38.3-canary.1278.16275.0

✨ Test out this PR locally via:

npm install @auto-canary/bot-list@9.38.3-canary.1278.16275.0
npm install @auto-canary/auto@9.38.3-canary.1278.16275.0
npm install @auto-canary/core@9.38.3-canary.1278.16275.0
npm install @auto-canary/all-contributors@9.38.3-canary.1278.16275.0
npm install @auto-canary/brew@9.38.3-canary.1278.16275.0
npm install @auto-canary/chrome@9.38.3-canary.1278.16275.0
npm install @auto-canary/cocoapods@9.38.3-canary.1278.16275.0
npm install @auto-canary/conventional-commits@9.38.3-canary.1278.16275.0
npm install @auto-canary/crates@9.38.3-canary.1278.16275.0
npm install @auto-canary/exec@9.38.3-canary.1278.16275.0
npm install @auto-canary/first-time-contributor@9.38.3-canary.1278.16275.0
npm install @auto-canary/gem@9.38.3-canary.1278.16275.0
npm install @auto-canary/gh-pages@9.38.3-canary.1278.16275.0
npm install @auto-canary/git-tag@9.38.3-canary.1278.16275.0
npm install @auto-canary/gradle@9.38.3-canary.1278.16275.0
npm install @auto-canary/jira@9.38.3-canary.1278.16275.0
npm install @auto-canary/maven@9.38.3-canary.1278.16275.0
npm install @auto-canary/npm@9.38.3-canary.1278.16275.0
npm install @auto-canary/omit-commits@9.38.3-canary.1278.16275.0
npm install @auto-canary/omit-release-notes@9.38.3-canary.1278.16275.0
npm install @auto-canary/released@9.38.3-canary.1278.16275.0
npm install @auto-canary/s3@9.38.3-canary.1278.16275.0
npm install @auto-canary/slack@9.38.3-canary.1278.16275.0
npm install @auto-canary/twitter@9.38.3-canary.1278.16275.0
npm install @auto-canary/upload-assets@9.38.3-canary.1278.16275.0
# or 
yarn add @auto-canary/bot-list@9.38.3-canary.1278.16275.0
yarn add @auto-canary/auto@9.38.3-canary.1278.16275.0
yarn add @auto-canary/core@9.38.3-canary.1278.16275.0
yarn add @auto-canary/all-contributors@9.38.3-canary.1278.16275.0
yarn add @auto-canary/brew@9.38.3-canary.1278.16275.0
yarn add @auto-canary/chrome@9.38.3-canary.1278.16275.0
yarn add @auto-canary/cocoapods@9.38.3-canary.1278.16275.0
yarn add @auto-canary/conventional-commits@9.38.3-canary.1278.16275.0
yarn add @auto-canary/crates@9.38.3-canary.1278.16275.0
yarn add @auto-canary/exec@9.38.3-canary.1278.16275.0
yarn add @auto-canary/first-time-contributor@9.38.3-canary.1278.16275.0
yarn add @auto-canary/gem@9.38.3-canary.1278.16275.0
yarn add @auto-canary/gh-pages@9.38.3-canary.1278.16275.0
yarn add @auto-canary/git-tag@9.38.3-canary.1278.16275.0
yarn add @auto-canary/gradle@9.38.3-canary.1278.16275.0
yarn add @auto-canary/jira@9.38.3-canary.1278.16275.0
yarn add @auto-canary/maven@9.38.3-canary.1278.16275.0
yarn add @auto-canary/npm@9.38.3-canary.1278.16275.0
yarn add @auto-canary/omit-commits@9.38.3-canary.1278.16275.0
yarn add @auto-canary/omit-release-notes@9.38.3-canary.1278.16275.0
yarn add @auto-canary/released@9.38.3-canary.1278.16275.0
yarn add @auto-canary/s3@9.38.3-canary.1278.16275.0
yarn add @auto-canary/slack@9.38.3-canary.1278.16275.0
yarn add @auto-canary/twitter@9.38.3-canary.1278.16275.0
yarn add @auto-canary/upload-assets@9.38.3-canary.1278.16275.0

@hipstersmoothie hipstersmoothie added the patch Increment the patch version when merged label Jun 5, 2020
@codecov
Copy link

codecov bot commented Jun 5, 2020

Codecov Report

Merging #1278 into master will increase coverage by 0.12%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1278      +/-   ##
==========================================
+ Coverage   81.06%   81.19%   +0.12%     
==========================================
  Files          56       56              
  Lines        4093     4094       +1     
  Branches      844      887      +43     
==========================================
+ Hits         3318     3324       +6     
+ Misses        552      548       -4     
+ Partials      223      222       -1     
Impacted Files Coverage Δ
packages/core/src/auto.ts 77.46% <100.00%> (+0.51%) ⬆️
packages/core/src/config.ts 90.80% <100.00%> (+1.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12a0d2e...07917bf. Read the comment docs.

@hipstersmoothie hipstersmoothie merged commit 5825aef into master Jun 5, 2020
@hipstersmoothie hipstersmoothie deleted the old-major-bug branch June 5, 2020 06:19
@adierkens
Copy link
Collaborator

🚀 PR was released in v9.39.0 🚀

@adierkens adierkens added the released This issue/pull request has been released. label Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

versionBranches fails on new major if branch does not exist
2 participants