Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update makeRelease to support 'from' and 'useVersion' options with build part of semver #1315

Merged

Conversation

bnigh
Copy link
Contributor

@bnigh bnigh commented Jun 24, 2020

What Changed

Why

  • This pr will allow users to support previous versions via build part of semver when manually specifying versions
    • eq doesn't account for build part of semver when comparing... this means that if a user specifies from=v1.2.3 & userVersion=v1.2.3+1, these would be treated as equal versions and the release would fail
    • compareBuild will account for the build part of semver when comparing, so the above scenario will succeed
  • relates to Hotfixes - Support Patches for old minors and patches #1054

Todo:

  • Add tests
📦 Published PR as canary version: under canary scope @auto-canary@9.39.1-canary.1315.16593.0

✨ Test out this PR locally via:

npm install @auto-canary/bot-list@9.39.1-canary.1315.16593.0
npm install @auto-canary/auto@9.39.1-canary.1315.16593.0
npm install @auto-canary/core@9.39.1-canary.1315.16593.0
npm install @auto-canary/all-contributors@9.39.1-canary.1315.16593.0
npm install @auto-canary/brew@9.39.1-canary.1315.16593.0
npm install @auto-canary/chrome@9.39.1-canary.1315.16593.0
npm install @auto-canary/cocoapods@9.39.1-canary.1315.16593.0
npm install @auto-canary/conventional-commits@9.39.1-canary.1315.16593.0
npm install @auto-canary/crates@9.39.1-canary.1315.16593.0
npm install @auto-canary/exec@9.39.1-canary.1315.16593.0
npm install @auto-canary/first-time-contributor@9.39.1-canary.1315.16593.0
npm install @auto-canary/gem@9.39.1-canary.1315.16593.0
npm install @auto-canary/gh-pages@9.39.1-canary.1315.16593.0
npm install @auto-canary/git-tag@9.39.1-canary.1315.16593.0
npm install @auto-canary/gradle@9.39.1-canary.1315.16593.0
npm install @auto-canary/jira@9.39.1-canary.1315.16593.0
npm install @auto-canary/maven@9.39.1-canary.1315.16593.0
npm install @auto-canary/npm@9.39.1-canary.1315.16593.0
npm install @auto-canary/omit-commits@9.39.1-canary.1315.16593.0
npm install @auto-canary/omit-release-notes@9.39.1-canary.1315.16593.0
npm install @auto-canary/released@9.39.1-canary.1315.16593.0
npm install @auto-canary/s3@9.39.1-canary.1315.16593.0
npm install @auto-canary/slack@9.39.1-canary.1315.16593.0
npm install @auto-canary/twitter@9.39.1-canary.1315.16593.0
npm install @auto-canary/upload-assets@9.39.1-canary.1315.16593.0
# or 
yarn add @auto-canary/bot-list@9.39.1-canary.1315.16593.0
yarn add @auto-canary/auto@9.39.1-canary.1315.16593.0
yarn add @auto-canary/core@9.39.1-canary.1315.16593.0
yarn add @auto-canary/all-contributors@9.39.1-canary.1315.16593.0
yarn add @auto-canary/brew@9.39.1-canary.1315.16593.0
yarn add @auto-canary/chrome@9.39.1-canary.1315.16593.0
yarn add @auto-canary/cocoapods@9.39.1-canary.1315.16593.0
yarn add @auto-canary/conventional-commits@9.39.1-canary.1315.16593.0
yarn add @auto-canary/crates@9.39.1-canary.1315.16593.0
yarn add @auto-canary/exec@9.39.1-canary.1315.16593.0
yarn add @auto-canary/first-time-contributor@9.39.1-canary.1315.16593.0
yarn add @auto-canary/gem@9.39.1-canary.1315.16593.0
yarn add @auto-canary/gh-pages@9.39.1-canary.1315.16593.0
yarn add @auto-canary/git-tag@9.39.1-canary.1315.16593.0
yarn add @auto-canary/gradle@9.39.1-canary.1315.16593.0
yarn add @auto-canary/jira@9.39.1-canary.1315.16593.0
yarn add @auto-canary/maven@9.39.1-canary.1315.16593.0
yarn add @auto-canary/npm@9.39.1-canary.1315.16593.0
yarn add @auto-canary/omit-commits@9.39.1-canary.1315.16593.0
yarn add @auto-canary/omit-release-notes@9.39.1-canary.1315.16593.0
yarn add @auto-canary/released@9.39.1-canary.1315.16593.0
yarn add @auto-canary/s3@9.39.1-canary.1315.16593.0
yarn add @auto-canary/slack@9.39.1-canary.1315.16593.0
yarn add @auto-canary/twitter@9.39.1-canary.1315.16593.0
yarn add @auto-canary/upload-assets@9.39.1-canary.1315.16593.0

@codecov
Copy link

codecov bot commented Jun 24, 2020

Codecov Report

Merging #1315 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1315   +/-   ##
=======================================
  Coverage   81.18%   81.18%           
=======================================
  Files          56       56           
  Lines        4097     4097           
  Branches      888      888           
=======================================
  Hits         3326     3326           
  Misses        548      548           
  Partials      223      223           
Impacted Files Coverage Δ
packages/core/src/auto.ts 77.46% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2613d77...96a7475. Read the comment docs.

@hipstersmoothie
Copy link
Collaborator

Ooooh perfect. Love seeing the tiny change that will lead to a much bigger feature 🎉

@hipstersmoothie hipstersmoothie added the patch Increment the patch version when merged label Jun 24, 2020
@hipstersmoothie hipstersmoothie merged commit 23735f8 into intuit:master Jun 24, 2020
@adierkens
Copy link
Collaborator

🚀 PR was released in v9.40.1 🚀

@adierkens adierkens added the released This issue/pull request has been released. label Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants