Update makeRelease to support 'from' and 'useVersion' options with build part of semver #1315
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Changed
compareBuild
instead ofeq
Why
eq
doesn't account for build part of semver when comparing... this means that if a user specifiesfrom=v1.2.3
&userVersion=v1.2.3+1
, these would be treated as equal versions and the release would failcompareBuild
will account for the build part of semver when comparing, so the above scenario will succeedTodo:
📦 Published PR as canary version:
under canary scope @auto-canary@9.39.1-canary.1315.16593.0
✨ Test out this PR locally via:
npm install @auto-canary/bot-list@9.39.1-canary.1315.16593.0 npm install @auto-canary/auto@9.39.1-canary.1315.16593.0 npm install @auto-canary/core@9.39.1-canary.1315.16593.0 npm install @auto-canary/all-contributors@9.39.1-canary.1315.16593.0 npm install @auto-canary/brew@9.39.1-canary.1315.16593.0 npm install @auto-canary/chrome@9.39.1-canary.1315.16593.0 npm install @auto-canary/cocoapods@9.39.1-canary.1315.16593.0 npm install @auto-canary/conventional-commits@9.39.1-canary.1315.16593.0 npm install @auto-canary/crates@9.39.1-canary.1315.16593.0 npm install @auto-canary/exec@9.39.1-canary.1315.16593.0 npm install @auto-canary/first-time-contributor@9.39.1-canary.1315.16593.0 npm install @auto-canary/gem@9.39.1-canary.1315.16593.0 npm install @auto-canary/gh-pages@9.39.1-canary.1315.16593.0 npm install @auto-canary/git-tag@9.39.1-canary.1315.16593.0 npm install @auto-canary/gradle@9.39.1-canary.1315.16593.0 npm install @auto-canary/jira@9.39.1-canary.1315.16593.0 npm install @auto-canary/maven@9.39.1-canary.1315.16593.0 npm install @auto-canary/npm@9.39.1-canary.1315.16593.0 npm install @auto-canary/omit-commits@9.39.1-canary.1315.16593.0 npm install @auto-canary/omit-release-notes@9.39.1-canary.1315.16593.0 npm install @auto-canary/released@9.39.1-canary.1315.16593.0 npm install @auto-canary/s3@9.39.1-canary.1315.16593.0 npm install @auto-canary/slack@9.39.1-canary.1315.16593.0 npm install @auto-canary/twitter@9.39.1-canary.1315.16593.0 npm install @auto-canary/upload-assets@9.39.1-canary.1315.16593.0 # or yarn add @auto-canary/bot-list@9.39.1-canary.1315.16593.0 yarn add @auto-canary/auto@9.39.1-canary.1315.16593.0 yarn add @auto-canary/core@9.39.1-canary.1315.16593.0 yarn add @auto-canary/all-contributors@9.39.1-canary.1315.16593.0 yarn add @auto-canary/brew@9.39.1-canary.1315.16593.0 yarn add @auto-canary/chrome@9.39.1-canary.1315.16593.0 yarn add @auto-canary/cocoapods@9.39.1-canary.1315.16593.0 yarn add @auto-canary/conventional-commits@9.39.1-canary.1315.16593.0 yarn add @auto-canary/crates@9.39.1-canary.1315.16593.0 yarn add @auto-canary/exec@9.39.1-canary.1315.16593.0 yarn add @auto-canary/first-time-contributor@9.39.1-canary.1315.16593.0 yarn add @auto-canary/gem@9.39.1-canary.1315.16593.0 yarn add @auto-canary/gh-pages@9.39.1-canary.1315.16593.0 yarn add @auto-canary/git-tag@9.39.1-canary.1315.16593.0 yarn add @auto-canary/gradle@9.39.1-canary.1315.16593.0 yarn add @auto-canary/jira@9.39.1-canary.1315.16593.0 yarn add @auto-canary/maven@9.39.1-canary.1315.16593.0 yarn add @auto-canary/npm@9.39.1-canary.1315.16593.0 yarn add @auto-canary/omit-commits@9.39.1-canary.1315.16593.0 yarn add @auto-canary/omit-release-notes@9.39.1-canary.1315.16593.0 yarn add @auto-canary/released@9.39.1-canary.1315.16593.0 yarn add @auto-canary/s3@9.39.1-canary.1315.16593.0 yarn add @auto-canary/slack@9.39.1-canary.1315.16593.0 yarn add @auto-canary/twitter@9.39.1-canary.1315.16593.0 yarn add @auto-canary/upload-assets@9.39.1-canary.1315.16593.0