Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix finding available canary version and add logging #1460

Merged
merged 1 commit into from
Aug 11, 2020

Conversation

hipstersmoothie
Copy link
Collaborator

@hipstersmoothie hipstersmoothie commented Aug 11, 2020

What Changed

On enterprise npm we weren't using the registry so auto wouldn't be able to find an available canary version.

Why

Running auto canary on the same commit should work

Todo:

  • Add tests
📦 Published PR as canary version: under canary scope @auto-canary@9.50.2-canary.1460.18098.0

✨ Test out this PR locally via:

npm install @auto-canary/bot-list@9.50.2-canary.1460.18098.0
npm install @auto-canary/auto@9.50.2-canary.1460.18098.0
npm install @auto-canary/core@9.50.2-canary.1460.18098.0
npm install @auto-canary/all-contributors@9.50.2-canary.1460.18098.0
npm install @auto-canary/brew@9.50.2-canary.1460.18098.0
npm install @auto-canary/chrome@9.50.2-canary.1460.18098.0
npm install @auto-canary/cocoapods@9.50.2-canary.1460.18098.0
npm install @auto-canary/conventional-commits@9.50.2-canary.1460.18098.0
npm install @auto-canary/crates@9.50.2-canary.1460.18098.0
npm install @auto-canary/exec@9.50.2-canary.1460.18098.0
npm install @auto-canary/first-time-contributor@9.50.2-canary.1460.18098.0
npm install @auto-canary/gem@9.50.2-canary.1460.18098.0
npm install @auto-canary/gh-pages@9.50.2-canary.1460.18098.0
npm install @auto-canary/git-tag@9.50.2-canary.1460.18098.0
npm install @auto-canary/gradle@9.50.2-canary.1460.18098.0
npm install @auto-canary/jira@9.50.2-canary.1460.18098.0
npm install @auto-canary/maven@9.50.2-canary.1460.18098.0
npm install @auto-canary/npm@9.50.2-canary.1460.18098.0
npm install @auto-canary/omit-commits@9.50.2-canary.1460.18098.0
npm install @auto-canary/omit-release-notes@9.50.2-canary.1460.18098.0
npm install @auto-canary/released@9.50.2-canary.1460.18098.0
npm install @auto-canary/s3@9.50.2-canary.1460.18098.0
npm install @auto-canary/slack@9.50.2-canary.1460.18098.0
npm install @auto-canary/twitter@9.50.2-canary.1460.18098.0
npm install @auto-canary/upload-assets@9.50.2-canary.1460.18098.0
# or 
yarn add @auto-canary/bot-list@9.50.2-canary.1460.18098.0
yarn add @auto-canary/auto@9.50.2-canary.1460.18098.0
yarn add @auto-canary/core@9.50.2-canary.1460.18098.0
yarn add @auto-canary/all-contributors@9.50.2-canary.1460.18098.0
yarn add @auto-canary/brew@9.50.2-canary.1460.18098.0
yarn add @auto-canary/chrome@9.50.2-canary.1460.18098.0
yarn add @auto-canary/cocoapods@9.50.2-canary.1460.18098.0
yarn add @auto-canary/conventional-commits@9.50.2-canary.1460.18098.0
yarn add @auto-canary/crates@9.50.2-canary.1460.18098.0
yarn add @auto-canary/exec@9.50.2-canary.1460.18098.0
yarn add @auto-canary/first-time-contributor@9.50.2-canary.1460.18098.0
yarn add @auto-canary/gem@9.50.2-canary.1460.18098.0
yarn add @auto-canary/gh-pages@9.50.2-canary.1460.18098.0
yarn add @auto-canary/git-tag@9.50.2-canary.1460.18098.0
yarn add @auto-canary/gradle@9.50.2-canary.1460.18098.0
yarn add @auto-canary/jira@9.50.2-canary.1460.18098.0
yarn add @auto-canary/maven@9.50.2-canary.1460.18098.0
yarn add @auto-canary/npm@9.50.2-canary.1460.18098.0
yarn add @auto-canary/omit-commits@9.50.2-canary.1460.18098.0
yarn add @auto-canary/omit-release-notes@9.50.2-canary.1460.18098.0
yarn add @auto-canary/released@9.50.2-canary.1460.18098.0
yarn add @auto-canary/s3@9.50.2-canary.1460.18098.0
yarn add @auto-canary/slack@9.50.2-canary.1460.18098.0
yarn add @auto-canary/twitter@9.50.2-canary.1460.18098.0
yarn add @auto-canary/upload-assets@9.50.2-canary.1460.18098.0

@hipstersmoothie hipstersmoothie added the patch Increment the patch version when merged label Aug 11, 2020
@codecov
Copy link

codecov bot commented Aug 11, 2020

Codecov Report

Merging #1460 into master will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1460      +/-   ##
==========================================
+ Coverage   81.05%   81.09%   +0.03%     
==========================================
  Files          58       58              
  Lines        4297     4300       +3     
  Branches      950      950              
==========================================
+ Hits         3483     3487       +4     
+ Misses        571      570       -1     
  Partials      243      243              
Impacted Files Coverage Δ
plugins/npm/src/index.ts 75.92% <100.00%> (+0.37%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0bffae9...2709ea9. Read the comment docs.

@hipstersmoothie hipstersmoothie merged commit 7254217 into master Aug 11, 2020
@hipstersmoothie hipstersmoothie deleted the npm-enterprise-available branch August 11, 2020 18:55
@adierkens
Copy link
Collaborator

🚀 PR was released in v9.50.2 🚀

@adierkens adierkens added the released This issue/pull request has been released. label Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants