correct behavior for lerna project with private packages #1472
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Changed
Previously that
npm
plugin would exit early iflerna changed
returned no changes. This didn't take into account private packages. Now we use the-a
flag to get those package changes too.Behavior:
canary
: No canaries will be published for private packages. This wouldn't make much sensenext
: A next version will be tagged and released for a private packagelatest
: private package will be versioned and tagged but not published.Why
There was a hole in the previous implementation where if the only package that changed was a private one a release would not happen.
closes #1463
Todo:
📦 Published PR as canary version:
under canary scope @auto-canary@9.50.8-canary.1472.18237.0
✨ Test out this PR locally via:
npm install @auto-canary/bot-list@9.50.8-canary.1472.18237.0 npm install @auto-canary/auto@9.50.8-canary.1472.18237.0 npm install @auto-canary/core@9.50.8-canary.1472.18237.0 npm install @auto-canary/all-contributors@9.50.8-canary.1472.18237.0 npm install @auto-canary/brew@9.50.8-canary.1472.18237.0 npm install @auto-canary/chrome@9.50.8-canary.1472.18237.0 npm install @auto-canary/cocoapods@9.50.8-canary.1472.18237.0 npm install @auto-canary/conventional-commits@9.50.8-canary.1472.18237.0 npm install @auto-canary/crates@9.50.8-canary.1472.18237.0 npm install @auto-canary/exec@9.50.8-canary.1472.18237.0 npm install @auto-canary/first-time-contributor@9.50.8-canary.1472.18237.0 npm install @auto-canary/gem@9.50.8-canary.1472.18237.0 npm install @auto-canary/gh-pages@9.50.8-canary.1472.18237.0 npm install @auto-canary/git-tag@9.50.8-canary.1472.18237.0 npm install @auto-canary/gradle@9.50.8-canary.1472.18237.0 npm install @auto-canary/jira@9.50.8-canary.1472.18237.0 npm install @auto-canary/maven@9.50.8-canary.1472.18237.0 npm install @auto-canary/npm@9.50.8-canary.1472.18237.0 npm install @auto-canary/omit-commits@9.50.8-canary.1472.18237.0 npm install @auto-canary/omit-release-notes@9.50.8-canary.1472.18237.0 npm install @auto-canary/released@9.50.8-canary.1472.18237.0 npm install @auto-canary/s3@9.50.8-canary.1472.18237.0 npm install @auto-canary/slack@9.50.8-canary.1472.18237.0 npm install @auto-canary/twitter@9.50.8-canary.1472.18237.0 npm install @auto-canary/upload-assets@9.50.8-canary.1472.18237.0 # or yarn add @auto-canary/bot-list@9.50.8-canary.1472.18237.0 yarn add @auto-canary/auto@9.50.8-canary.1472.18237.0 yarn add @auto-canary/core@9.50.8-canary.1472.18237.0 yarn add @auto-canary/all-contributors@9.50.8-canary.1472.18237.0 yarn add @auto-canary/brew@9.50.8-canary.1472.18237.0 yarn add @auto-canary/chrome@9.50.8-canary.1472.18237.0 yarn add @auto-canary/cocoapods@9.50.8-canary.1472.18237.0 yarn add @auto-canary/conventional-commits@9.50.8-canary.1472.18237.0 yarn add @auto-canary/crates@9.50.8-canary.1472.18237.0 yarn add @auto-canary/exec@9.50.8-canary.1472.18237.0 yarn add @auto-canary/first-time-contributor@9.50.8-canary.1472.18237.0 yarn add @auto-canary/gem@9.50.8-canary.1472.18237.0 yarn add @auto-canary/gh-pages@9.50.8-canary.1472.18237.0 yarn add @auto-canary/git-tag@9.50.8-canary.1472.18237.0 yarn add @auto-canary/gradle@9.50.8-canary.1472.18237.0 yarn add @auto-canary/jira@9.50.8-canary.1472.18237.0 yarn add @auto-canary/maven@9.50.8-canary.1472.18237.0 yarn add @auto-canary/npm@9.50.8-canary.1472.18237.0 yarn add @auto-canary/omit-commits@9.50.8-canary.1472.18237.0 yarn add @auto-canary/omit-release-notes@9.50.8-canary.1472.18237.0 yarn add @auto-canary/released@9.50.8-canary.1472.18237.0 yarn add @auto-canary/s3@9.50.8-canary.1472.18237.0 yarn add @auto-canary/slack@9.50.8-canary.1472.18237.0 yarn add @auto-canary/twitter@9.50.8-canary.1472.18237.0 yarn add @auto-canary/upload-assets@9.50.8-canary.1472.18237.0