Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve pr-check usage + don't fail on runs in CI base branch #1636

Merged
merged 3 commits into from
Nov 6, 2020

Conversation

hipstersmoothie
Copy link
Collaborator

@hipstersmoothie hipstersmoothie commented Nov 6, 2020

Release Notes

Previously when using auto pr-check you would have to check that you were running the command from a PR with bash scripting so it didn't fail when running on master.

This PR simplifies this workflow so that you can run auto pr-check without any logic. On CI + base branch pr-check will exit successfully, otherwise it will check for a PR number and fail accordingly.

Why

Less config + more automation = happy auto consumers

Todo:

  • Add tests
  • Add docs

Change Type

Indicate the type of change your pull request is:

  • documentation
  • patch
  • minor
  • major
📦 Published PR as canary version: under canary scope @auto-canary@10.2.5-canary.1636.20195.0

✨ Test out this PR locally via:

npm install @auto-canary/bot-list@10.2.5-canary.1636.20195.0
npm install @auto-canary/auto@10.2.5-canary.1636.20195.0
npm install @auto-canary/core@10.2.5-canary.1636.20195.0
npm install @auto-canary/all-contributors@10.2.5-canary.1636.20195.0
npm install @auto-canary/brew@10.2.5-canary.1636.20195.0
npm install @auto-canary/chrome@10.2.5-canary.1636.20195.0
npm install @auto-canary/cocoapods@10.2.5-canary.1636.20195.0
npm install @auto-canary/conventional-commits@10.2.5-canary.1636.20195.0
npm install @auto-canary/crates@10.2.5-canary.1636.20195.0
npm install @auto-canary/docker@10.2.5-canary.1636.20195.0
npm install @auto-canary/exec@10.2.5-canary.1636.20195.0
npm install @auto-canary/first-time-contributor@10.2.5-canary.1636.20195.0
npm install @auto-canary/gem@10.2.5-canary.1636.20195.0
npm install @auto-canary/gh-pages@10.2.5-canary.1636.20195.0
npm install @auto-canary/git-tag@10.2.5-canary.1636.20195.0
npm install @auto-canary/gradle@10.2.5-canary.1636.20195.0
npm install @auto-canary/jira@10.2.5-canary.1636.20195.0
npm install @auto-canary/maven@10.2.5-canary.1636.20195.0
npm install @auto-canary/microsoft-teams@10.2.5-canary.1636.20195.0
npm install @auto-canary/npm@10.2.5-canary.1636.20195.0
npm install @auto-canary/omit-commits@10.2.5-canary.1636.20195.0
npm install @auto-canary/omit-release-notes@10.2.5-canary.1636.20195.0
npm install @auto-canary/pr-body-labels@10.2.5-canary.1636.20195.0
npm install @auto-canary/released@10.2.5-canary.1636.20195.0
npm install @auto-canary/s3@10.2.5-canary.1636.20195.0
npm install @auto-canary/slack@10.2.5-canary.1636.20195.0
npm install @auto-canary/twitter@10.2.5-canary.1636.20195.0
npm install @auto-canary/upload-assets@10.2.5-canary.1636.20195.0
# or 
yarn add @auto-canary/bot-list@10.2.5-canary.1636.20195.0
yarn add @auto-canary/auto@10.2.5-canary.1636.20195.0
yarn add @auto-canary/core@10.2.5-canary.1636.20195.0
yarn add @auto-canary/all-contributors@10.2.5-canary.1636.20195.0
yarn add @auto-canary/brew@10.2.5-canary.1636.20195.0
yarn add @auto-canary/chrome@10.2.5-canary.1636.20195.0
yarn add @auto-canary/cocoapods@10.2.5-canary.1636.20195.0
yarn add @auto-canary/conventional-commits@10.2.5-canary.1636.20195.0
yarn add @auto-canary/crates@10.2.5-canary.1636.20195.0
yarn add @auto-canary/docker@10.2.5-canary.1636.20195.0
yarn add @auto-canary/exec@10.2.5-canary.1636.20195.0
yarn add @auto-canary/first-time-contributor@10.2.5-canary.1636.20195.0
yarn add @auto-canary/gem@10.2.5-canary.1636.20195.0
yarn add @auto-canary/gh-pages@10.2.5-canary.1636.20195.0
yarn add @auto-canary/git-tag@10.2.5-canary.1636.20195.0
yarn add @auto-canary/gradle@10.2.5-canary.1636.20195.0
yarn add @auto-canary/jira@10.2.5-canary.1636.20195.0
yarn add @auto-canary/maven@10.2.5-canary.1636.20195.0
yarn add @auto-canary/microsoft-teams@10.2.5-canary.1636.20195.0
yarn add @auto-canary/npm@10.2.5-canary.1636.20195.0
yarn add @auto-canary/omit-commits@10.2.5-canary.1636.20195.0
yarn add @auto-canary/omit-release-notes@10.2.5-canary.1636.20195.0
yarn add @auto-canary/pr-body-labels@10.2.5-canary.1636.20195.0
yarn add @auto-canary/released@10.2.5-canary.1636.20195.0
yarn add @auto-canary/s3@10.2.5-canary.1636.20195.0
yarn add @auto-canary/slack@10.2.5-canary.1636.20195.0
yarn add @auto-canary/twitter@10.2.5-canary.1636.20195.0
yarn add @auto-canary/upload-assets@10.2.5-canary.1636.20195.0

@adierkens adierkens added the patch Increment the patch version when merged label Nov 6, 2020
@codecov
Copy link

codecov bot commented Nov 6, 2020

Codecov Report

Merging #1636 (e77ab8e) into master (ec34caf) will decrease coverage by 0.00%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1636      +/-   ##
==========================================
- Coverage   80.27%   80.27%   -0.01%     
==========================================
  Files          61       61              
  Lines        4655     4660       +5     
  Branches     1009     1011       +2     
==========================================
+ Hits         3737     3741       +4     
  Misses        632      632              
- Partials      286      287       +1     
Impacted Files Coverage Δ
packages/cli/src/parse-args.ts 97.29% <ø> (ø)
packages/core/src/auto.ts 78.41% <83.33%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec34caf...e77ab8e. Read the comment docs.

@hipstersmoothie hipstersmoothie merged commit 8e7b76f into master Nov 6, 2020
@hipstersmoothie hipstersmoothie deleted the pr-check branch November 6, 2020 19:05
@adierkens
Copy link
Collaborator

🚀 PR was released in v10.2.5 🚀

@adierkens adierkens added the released This issue/pull request has been released. label Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants