Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security] Bump ini from 1.3.5 to 1.3.8 #1689

Merged
merged 1 commit into from
Jan 4, 2021

Conversation

dependabot-preview[bot]
Copy link
Contributor

@dependabot-preview dependabot-preview bot commented Dec 14, 2020

Bumps ini from 1.3.5 to 1.3.8. This update includes a security fix.

Vulnerabilities fixed

Sourced from The GitHub Security Advisory Database.

Prototype Pollution

Overview

The ini npm package before version 1.3.6 has a Prototype Pollution vulnerability.

If an attacker submits a malicious INI file to an application that parses it with ini.parse, they will pollute the prototype on the application. This can be exploited further depending on the context.

Patches

This has been patched in 1.3.6

Steps to reproduce

payload.ini

[__proto__]
polluted = "polluted"

poc.js:

var fs = require('fs')
</tr></table> ... (truncated)

Affected versions: < 1.3.6

Commits
  • a2c5da8 1.3.8
  • af5c6bb Do not use Object.create(null)
  • 8b648a1 don't test where our devdeps don't even work
  • c74c8af 1.3.7
  • 024b8b5 update deps, add linting
  • 032fbaf Use Object.create(null) to avoid default object property hazards
  • 2da9039 1.3.6
  • cfea636 better git push script, before publish instead of after
  • 56d2805 do not allow invalid hazardous string as section name
  • See full diff in compare view
Maintainer changes

This version was pushed to npm by isaacs, a new releaser for ini since your current version.


Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)
📦 Published PR as canary version: under canary scope @auto-canary@10.5.1-canary.1689.20814.0

✨ Test out this PR locally via:

npm install @auto-canary/bot-list@10.5.1-canary.1689.20814.0
npm install @auto-canary/auto@10.5.1-canary.1689.20814.0
npm install @auto-canary/core@10.5.1-canary.1689.20814.0
npm install @auto-canary/package-json-utils@10.5.1-canary.1689.20814.0
npm install @auto-canary/all-contributors@10.5.1-canary.1689.20814.0
npm install @auto-canary/brew@10.5.1-canary.1689.20814.0
npm install @auto-canary/chrome@10.5.1-canary.1689.20814.0
npm install @auto-canary/cocoapods@10.5.1-canary.1689.20814.0
npm install @auto-canary/conventional-commits@10.5.1-canary.1689.20814.0
npm install @auto-canary/crates@10.5.1-canary.1689.20814.0
npm install @auto-canary/docker@10.5.1-canary.1689.20814.0
npm install @auto-canary/exec@10.5.1-canary.1689.20814.0
npm install @auto-canary/first-time-contributor@10.5.1-canary.1689.20814.0
npm install @auto-canary/gem@10.5.1-canary.1689.20814.0
npm install @auto-canary/gh-pages@10.5.1-canary.1689.20814.0
npm install @auto-canary/git-tag@10.5.1-canary.1689.20814.0
npm install @auto-canary/gradle@10.5.1-canary.1689.20814.0
npm install @auto-canary/jira@10.5.1-canary.1689.20814.0
npm install @auto-canary/maven@10.5.1-canary.1689.20814.0
npm install @auto-canary/microsoft-teams@10.5.1-canary.1689.20814.0
npm install @auto-canary/npm@10.5.1-canary.1689.20814.0
npm install @auto-canary/omit-commits@10.5.1-canary.1689.20814.0
npm install @auto-canary/omit-release-notes@10.5.1-canary.1689.20814.0
npm install @auto-canary/pr-body-labels@10.5.1-canary.1689.20814.0
npm install @auto-canary/released@10.5.1-canary.1689.20814.0
npm install @auto-canary/s3@10.5.1-canary.1689.20814.0
npm install @auto-canary/slack@10.5.1-canary.1689.20814.0
npm install @auto-canary/twitter@10.5.1-canary.1689.20814.0
npm install @auto-canary/upload-assets@10.5.1-canary.1689.20814.0
npm install @auto-canary/vscode@10.5.1-canary.1689.20814.0
# or 
yarn add @auto-canary/bot-list@10.5.1-canary.1689.20814.0
yarn add @auto-canary/auto@10.5.1-canary.1689.20814.0
yarn add @auto-canary/core@10.5.1-canary.1689.20814.0
yarn add @auto-canary/package-json-utils@10.5.1-canary.1689.20814.0
yarn add @auto-canary/all-contributors@10.5.1-canary.1689.20814.0
yarn add @auto-canary/brew@10.5.1-canary.1689.20814.0
yarn add @auto-canary/chrome@10.5.1-canary.1689.20814.0
yarn add @auto-canary/cocoapods@10.5.1-canary.1689.20814.0
yarn add @auto-canary/conventional-commits@10.5.1-canary.1689.20814.0
yarn add @auto-canary/crates@10.5.1-canary.1689.20814.0
yarn add @auto-canary/docker@10.5.1-canary.1689.20814.0
yarn add @auto-canary/exec@10.5.1-canary.1689.20814.0
yarn add @auto-canary/first-time-contributor@10.5.1-canary.1689.20814.0
yarn add @auto-canary/gem@10.5.1-canary.1689.20814.0
yarn add @auto-canary/gh-pages@10.5.1-canary.1689.20814.0
yarn add @auto-canary/git-tag@10.5.1-canary.1689.20814.0
yarn add @auto-canary/gradle@10.5.1-canary.1689.20814.0
yarn add @auto-canary/jira@10.5.1-canary.1689.20814.0
yarn add @auto-canary/maven@10.5.1-canary.1689.20814.0
yarn add @auto-canary/microsoft-teams@10.5.1-canary.1689.20814.0
yarn add @auto-canary/npm@10.5.1-canary.1689.20814.0
yarn add @auto-canary/omit-commits@10.5.1-canary.1689.20814.0
yarn add @auto-canary/omit-release-notes@10.5.1-canary.1689.20814.0
yarn add @auto-canary/pr-body-labels@10.5.1-canary.1689.20814.0
yarn add @auto-canary/released@10.5.1-canary.1689.20814.0
yarn add @auto-canary/s3@10.5.1-canary.1689.20814.0
yarn add @auto-canary/slack@10.5.1-canary.1689.20814.0
yarn add @auto-canary/twitter@10.5.1-canary.1689.20814.0
yarn add @auto-canary/upload-assets@10.5.1-canary.1689.20814.0
yarn add @auto-canary/vscode@10.5.1-canary.1689.20814.0

@dependabot-preview dependabot-preview bot added dependencies Update one or more dependencies version security Pull requests that address a security vulnerability labels Dec 14, 2020
@codecov
Copy link

codecov bot commented Dec 14, 2020

Codecov Report

Merging #1689 (4c6adc6) into master (3d8d3a0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1689   +/-   ##
=======================================
  Coverage   79.89%   79.89%           
=======================================
  Files          63       63           
  Lines        4730     4730           
  Branches     1023     1074   +51     
=======================================
  Hits         3779     3779           
  Misses        660      660           
  Partials      291      291           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d8d3a0...4c6adc6. Read the comment docs.

Bumps [ini](https://github.com/isaacs/ini) from 1.3.5 to 1.3.8. **This update includes a security fix.**
- [Release notes](https://github.com/isaacs/ini/releases)
- [Commits](npm/ini@v1.3.5...v1.3.8)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/ini-1.3.8 branch from 8013acf to 4c6adc6 Compare December 21, 2020 21:21
@hipstersmoothie hipstersmoothie merged commit 61f0084 into master Jan 4, 2021
@hipstersmoothie hipstersmoothie deleted the dependabot/npm_and_yarn/ini-1.3.8 branch January 4, 2021 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Update one or more dependencies version security Pull requests that address a security vulnerability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant