Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @auto-it/magic-zero Plugin #1701

Merged
merged 5 commits into from
Jan 25, 2021
Merged

Add @auto-it/magic-zero Plugin #1701

merged 5 commits into from
Jan 25, 2021

Conversation

hipstersmoothie
Copy link
Collaborator

@hipstersmoothie hipstersmoothie commented Jan 6, 2021

What Changed

A plugin that closely adheres to semver versioning for 0.0.x and 0.x.y releases.

Why

closes #1699

Todo:

  • Add tests
  • Add docs

Change Type

Indicate the type of change your pull request is:

  • documentation
  • patch
  • minor
  • major
📦 Published PR as canary version: under canary scope @auto-canary@10.5.1-canary.1701.20906.0

✨ Test out this PR locally via:

npm install @auto-canary/bot-list@10.5.1-canary.1701.20906.0
npm install @auto-canary/auto@10.5.1-canary.1701.20906.0
npm install @auto-canary/core@10.5.1-canary.1701.20906.0
npm install @auto-canary/package-json-utils@10.5.1-canary.1701.20906.0
npm install @auto-canary/all-contributors@10.5.1-canary.1701.20906.0
npm install @auto-canary/brew@10.5.1-canary.1701.20906.0
npm install @auto-canary/chrome@10.5.1-canary.1701.20906.0
npm install @auto-canary/cocoapods@10.5.1-canary.1701.20906.0
npm install @auto-canary/conventional-commits@10.5.1-canary.1701.20906.0
npm install @auto-canary/crates@10.5.1-canary.1701.20906.0
npm install @auto-canary/docker@10.5.1-canary.1701.20906.0
npm install @auto-canary/exec@10.5.1-canary.1701.20906.0
npm install @auto-canary/first-time-contributor@10.5.1-canary.1701.20906.0
npm install @auto-canary/gem@10.5.1-canary.1701.20906.0
npm install @auto-canary/gh-pages@10.5.1-canary.1701.20906.0
npm install @auto-canary/git-tag@10.5.1-canary.1701.20906.0
npm install @auto-canary/gradle@10.5.1-canary.1701.20906.0
npm install @auto-canary/jira@10.5.1-canary.1701.20906.0
npm install @auto-canary/magic-zero@10.5.1-canary.1701.20906.0
npm install @auto-canary/maven@10.5.1-canary.1701.20906.0
npm install @auto-canary/microsoft-teams@10.5.1-canary.1701.20906.0
npm install @auto-canary/npm@10.5.1-canary.1701.20906.0
npm install @auto-canary/omit-commits@10.5.1-canary.1701.20906.0
npm install @auto-canary/omit-release-notes@10.5.1-canary.1701.20906.0
npm install @auto-canary/pr-body-labels@10.5.1-canary.1701.20906.0
npm install @auto-canary/released@10.5.1-canary.1701.20906.0
npm install @auto-canary/s3@10.5.1-canary.1701.20906.0
npm install @auto-canary/slack@10.5.1-canary.1701.20906.0
npm install @auto-canary/twitter@10.5.1-canary.1701.20906.0
npm install @auto-canary/upload-assets@10.5.1-canary.1701.20906.0
npm install @auto-canary/vscode@10.5.1-canary.1701.20906.0
# or 
yarn add @auto-canary/bot-list@10.5.1-canary.1701.20906.0
yarn add @auto-canary/auto@10.5.1-canary.1701.20906.0
yarn add @auto-canary/core@10.5.1-canary.1701.20906.0
yarn add @auto-canary/package-json-utils@10.5.1-canary.1701.20906.0
yarn add @auto-canary/all-contributors@10.5.1-canary.1701.20906.0
yarn add @auto-canary/brew@10.5.1-canary.1701.20906.0
yarn add @auto-canary/chrome@10.5.1-canary.1701.20906.0
yarn add @auto-canary/cocoapods@10.5.1-canary.1701.20906.0
yarn add @auto-canary/conventional-commits@10.5.1-canary.1701.20906.0
yarn add @auto-canary/crates@10.5.1-canary.1701.20906.0
yarn add @auto-canary/docker@10.5.1-canary.1701.20906.0
yarn add @auto-canary/exec@10.5.1-canary.1701.20906.0
yarn add @auto-canary/first-time-contributor@10.5.1-canary.1701.20906.0
yarn add @auto-canary/gem@10.5.1-canary.1701.20906.0
yarn add @auto-canary/gh-pages@10.5.1-canary.1701.20906.0
yarn add @auto-canary/git-tag@10.5.1-canary.1701.20906.0
yarn add @auto-canary/gradle@10.5.1-canary.1701.20906.0
yarn add @auto-canary/jira@10.5.1-canary.1701.20906.0
yarn add @auto-canary/magic-zero@10.5.1-canary.1701.20906.0
yarn add @auto-canary/maven@10.5.1-canary.1701.20906.0
yarn add @auto-canary/microsoft-teams@10.5.1-canary.1701.20906.0
yarn add @auto-canary/npm@10.5.1-canary.1701.20906.0
yarn add @auto-canary/omit-commits@10.5.1-canary.1701.20906.0
yarn add @auto-canary/omit-release-notes@10.5.1-canary.1701.20906.0
yarn add @auto-canary/pr-body-labels@10.5.1-canary.1701.20906.0
yarn add @auto-canary/released@10.5.1-canary.1701.20906.0
yarn add @auto-canary/s3@10.5.1-canary.1701.20906.0
yarn add @auto-canary/slack@10.5.1-canary.1701.20906.0
yarn add @auto-canary/twitter@10.5.1-canary.1701.20906.0
yarn add @auto-canary/upload-assets@10.5.1-canary.1701.20906.0
yarn add @auto-canary/vscode@10.5.1-canary.1701.20906.0

@adierkens adierkens added the minor Increment the minor version when merged label Jan 6, 2021
@codecov
Copy link

codecov bot commented Jan 6, 2021

Codecov Report

Merging #1701 (b51746e) into main (99d4c0e) will increase coverage by 0.13%.
The diff coverage is 97.29%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1701      +/-   ##
==========================================
+ Coverage   79.89%   80.02%   +0.13%     
==========================================
  Files          63       64       +1     
  Lines        4730     4766      +36     
  Branches     1074     1084      +10     
==========================================
+ Hits         3779     3814      +35     
- Misses        660      661       +1     
  Partials      291      291              
Impacted Files Coverage Δ
packages/core/src/utils/make-hooks.ts 100.00% <ø> (ø)
plugins/magic-zero/src/index.ts 97.22% <97.22%> (ø)
packages/core/src/auto.ts 78.41% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99d4c0e...b51746e. Read the comment docs.

Base automatically changed from master to main January 20, 2021 19:54
@aleclarson
Copy link
Contributor

This seems like a fine solution 👍

@aleclarson

This comment has been minimized.

@aleclarson
Copy link
Contributor

Ah nevermind. I see the core also has changes here. Sorry!

@aleclarson
Copy link
Contributor

Okay, even after installing the canary versions of all plugins + the core:

Error: Auto is not initialized! Make sure the have run Auto.loadConfig
    at Auto.createErrorMessage (~/.nvm/versions/node/v14.15.3/pnpm-global/4/node_modules/.pnpm/@auto-canary/core@10.5.1-canary.1701.20906.0/node_modules/@auto-canary/core/dist/auto.js:1186:16)
    at Auto.prefixRelease (~/.nvm/versions/node/v14.15.3/pnpm-global/4/node_modules/.pnpm/@auto-canary/core@10.5.1-canary.1701.20906.0/node_modules/@auto-canary/core/dist/auto.js:120:28)
    at getPreviousVersion (~/dev/oss/cloudflare-bundler/node_modules/.pnpm/@auto-canary/npm@10.5.1-canary.1701.20906.0/node_modules/@auto-canary/npm/dist/index.js:181:67)

..when running:

auto release --use-version v0.2.2

@hipstersmoothie hipstersmoothie merged commit e230f0a into main Jan 25, 2021
@hipstersmoothie hipstersmoothie deleted the magic-zero branch January 25, 2021 17:05
@adierkens
Copy link
Collaborator

🚀 PR was released in v10.13.0 🚀

@adierkens adierkens added the released This issue/pull request has been released. label Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Increment the minor version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

conventional-commits bumps 0.x versions incorrectly
3 participants