-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat add afterRun
hook
#2182
Feat add afterRun
hook
#2182
Conversation
Just like #2180 , I didn't understand why ci check |
I think this would mean that we have to update anywhere we use the afterShipIt hook since right now we assume we are shipping something. This would also be a breaking change too since it could break people using the hook |
This is not really a breaking change since the hook payload permit it and the purpose of this hook seems to be : I see two options :
I'll be glad to handle this. Please let me known what is your preference ? |
@jBouyoud Route 2 sounds like a great option! I like how we would then have the beforeRun/afterRun combo. |
afterShipIt
hook even when no release is doneafterRun
hook
c37efe4
to
2bea759
Compare
dfa44e1
to
ed64c9d
Compare
@hipstersmoothie please find an implementation proposal for the route 2 |
@hipstersmoothie anything that I can do to help merge this PR ? |
ed64c9d
to
b4df2fd
Compare
@hipstersmoothie I also rebase this PR ;-P |
b4df2fd
to
895cfae
Compare
And github actions permissions are all in |
@hipstersmoothie Let me know if everything miss to merge this |
🚀 PR was released in |
What Changed
Add new
afterRun
hook triggered after each command.Why
Because
beforeRun
exists ;-PTodo:
Change Type
Indicate the type of change your pull request is:
documentation
patch
minor
major