Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix esm css.js output #709

Merged
merged 1 commit into from
Dec 26, 2022
Merged

fix esm css.js output #709

merged 1 commit into from
Dec 26, 2022

Conversation

hipstersmoothie
Copy link
Contributor

@hipstersmoothie hipstersmoothie commented Dec 26, 2022

What Changed

Previously we were outputting cjs code to the esm files

Why

I was trying to use code output by this tool in vite and the imports for css were breaking the build.

📦 Published PR as canary version: 4.15.2--canary.709.19992.0

✨ Test out this PR locally via:

npm install @design-systems/babel-plugin-include-styles@4.15.2--canary.709.19992.0
npm install @design-systems/babel-plugin-replace-styles@4.15.2--canary.709.19992.0
npm install @design-systems/cli-utils@4.15.2--canary.709.19992.0
npm install @design-systems/cli@4.15.2--canary.709.19992.0
npm install @design-systems/core@4.15.2--canary.709.19992.0
npm install @design-systems/create@4.15.2--canary.709.19992.0
npm install @design-systems/eslint-config@4.15.2--canary.709.19992.0
npm install @design-systems/hooks@4.15.2--canary.709.19992.0
npm install @design-systems/load-config@4.15.2--canary.709.19992.0
npm install @design-systems/next-esm-css@4.15.2--canary.709.19992.0
npm install @design-systems/plugin@4.15.2--canary.709.19992.0
npm install @design-systems/stylelint-config@4.15.2--canary.709.19992.0
npm install @design-systems/svg-icon-builder@4.15.2--canary.709.19992.0
npm install @design-systems/utils@4.15.2--canary.709.19992.0
npm install @design-systems/build@4.15.2--canary.709.19992.0
npm install @design-systems/bundle@4.15.2--canary.709.19992.0
npm install @design-systems/clean@4.15.2--canary.709.19992.0
npm install @design-systems/create-command@4.15.2--canary.709.19992.0
npm install @design-systems/dev@4.15.2--canary.709.19992.0
npm install @design-systems/lint@4.15.2--canary.709.19992.0
npm install @design-systems/playroom@4.15.2--canary.709.19992.0
npm install @design-systems/proof@4.15.2--canary.709.19992.0
npm install @design-systems/size@4.15.2--canary.709.19992.0
npm install @design-systems/storybook@4.15.2--canary.709.19992.0
npm install @design-systems/test@4.15.2--canary.709.19992.0
npm install @design-systems/update@4.15.2--canary.709.19992.0
# or 
yarn add @design-systems/babel-plugin-include-styles@4.15.2--canary.709.19992.0
yarn add @design-systems/babel-plugin-replace-styles@4.15.2--canary.709.19992.0
yarn add @design-systems/cli-utils@4.15.2--canary.709.19992.0
yarn add @design-systems/cli@4.15.2--canary.709.19992.0
yarn add @design-systems/core@4.15.2--canary.709.19992.0
yarn add @design-systems/create@4.15.2--canary.709.19992.0
yarn add @design-systems/eslint-config@4.15.2--canary.709.19992.0
yarn add @design-systems/hooks@4.15.2--canary.709.19992.0
yarn add @design-systems/load-config@4.15.2--canary.709.19992.0
yarn add @design-systems/next-esm-css@4.15.2--canary.709.19992.0
yarn add @design-systems/plugin@4.15.2--canary.709.19992.0
yarn add @design-systems/stylelint-config@4.15.2--canary.709.19992.0
yarn add @design-systems/svg-icon-builder@4.15.2--canary.709.19992.0
yarn add @design-systems/utils@4.15.2--canary.709.19992.0
yarn add @design-systems/build@4.15.2--canary.709.19992.0
yarn add @design-systems/bundle@4.15.2--canary.709.19992.0
yarn add @design-systems/clean@4.15.2--canary.709.19992.0
yarn add @design-systems/create-command@4.15.2--canary.709.19992.0
yarn add @design-systems/dev@4.15.2--canary.709.19992.0
yarn add @design-systems/lint@4.15.2--canary.709.19992.0
yarn add @design-systems/playroom@4.15.2--canary.709.19992.0
yarn add @design-systems/proof@4.15.2--canary.709.19992.0
yarn add @design-systems/size@4.15.2--canary.709.19992.0
yarn add @design-systems/storybook@4.15.2--canary.709.19992.0
yarn add @design-systems/test@4.15.2--canary.709.19992.0
yarn add @design-systems/update@4.15.2--canary.709.19992.0

@hipstersmoothie hipstersmoothie merged commit 19719ab into master Dec 26, 2022
@hipstersmoothie hipstersmoothie deleted the fix-esm branch December 26, 2022 23:45
@hipstersmoothie hipstersmoothie added the patch Increment the patch version when merged label Dec 26, 2022
@hipstersmoothie
Copy link
Contributor Author

🚀 PR was released in v4.15.2 🚀

@hipstersmoothie hipstersmoothie added the released This issue/pull request has been released. label Dec 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant