-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update and clean up JSDocs #38 #39
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -23,8 +23,8 @@ type ParseCallback=(e: Error | null, r?: ParsedOutput | null) => void; | |
|
||
/** | ||
* Parses xml into javascript object by using a file path or an xml content. | ||
* @param {object} opt Is the option with the filePath or xmlContent and the optional format. | ||
* @return {object} The pom object along with the timers. | ||
* @param {*} opt Is the option with the filePath or xmlContent and the optional format. | ||
* @param {*} callback The pom object along with the timers. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fix up the leading text to param, and also use TS type. |
||
*/ | ||
function parse(opt: ParseOptions,callback: ParseCallback): void { | ||
if (!opt) { | ||
|
@@ -65,8 +65,6 @@ function parse(opt: ParseOptions,callback: ParseCallback): void { | |
/** | ||
* Parses the given xml content. | ||
* @param xmlContent {string} Is the xml content in string using utf-8 format. | ||
* @param loadedXml {boolean} Whether the xml was loaded from the file-system. | ||
* @param callback {function} The callback function using Javascript PCS. | ||
*/ | ||
function _parseWithXml2js(xmlContent: string): Promise<ParsedOutput> { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Missing |
||
return new Promise(function (resolve, reject) { | ||
|
@@ -103,6 +101,12 @@ function removeSingleArrays(obj: Object):void { | |
}); | ||
} | ||
|
||
/** | ||
* Reads a file in Async mode | ||
* @param {*} path is the file path | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Change type to |
||
* @param {*} encoding is the type on encoding used in the file | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Use correct type here. |
||
* @returns | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Missing |
||
*/ | ||
function readFileAsync(path: string, encoding: BufferEncoding | undefined): Promise<string> { | ||
return new Promise((resolve, reject) => | ||
fs.readFile(path, { encoding }, (err, data) => { | ||
|
@@ -117,4 +121,4 @@ function readFileAsync(path: string, encoding: BufferEncoding | undefined): Prom | |
); | ||
} | ||
|
||
export default parse; | ||
export default parse; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of
*
use the TS type here.