Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(OAuthClient) Add Additional unit tests for OAuthClient (#47) #49

Merged

Conversation

edgarsherman
Copy link
Contributor

  • Added tests for OAuthClient to bring test coverage higher
  • re-worked logic in OAuthClient.createError to be more consistent

*I'll try and add more tests throughout the month, but I might not get to it for a bit.

- Added tests for OAuthClient to bring test coverage higher
- re-worked logic in OAuthClient.createError to be more consistent
@abisalehalliprasan
Copy link
Collaborator

abisalehalliprasan commented Oct 16, 2019

Good work @edgarsherman 👏 . The improved test coverage is [here] for #47 (https://tinyurl.com/y5smqb72)

@abisalehalliprasan
Copy link
Collaborator

🚀 PR was released in v2.0.0 hacktoberfest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants