Accept Full Range of HTTP Success Codes #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
Merged
abisalehalliprasan
added a commit
that referenced
this pull request
Apr 10, 2020
* Accept HTTP status codes between 199 and 300 as successes (#78) * Fix: handle not JSON content in response parsing (#59) * Coveralls Badge Fix * Coveralls Badge Fix:Final * Coveralls Badge Fix : istanbul package added * Coveralls Badge Fix + snyk added * Coveralls Badge Fix + snyk added * Snyk removed from Makefile * Snyk removed for timebeing * Add more code coverage for OAuthClient (#54) * Add better code coverage in OAuthClient * Fix: ValidateIdToken method and unit tests (#58) * Fix validateIdToken tests * Pointing README Badge to Develop * Pointing README Badge to Develop * Update Develop Coverage Badge * Fix: handle not JSON content in response parsing Some intuit API as invoice download return not JSON content (PDF in this case). `makeApiCall` wasn't working with it because of mandatory response body parsing. So if the response is not JSON, we don't want to parse the body. And simply let the caller decide what to do with it. Co-authored-by: abisalehalliprasan <anil_kumar3@intuit.com> Co-authored-by: Oscar Rabasa <oscargrp@gmail.com> Co-authored-by: Kevin Tang <kevin.hm.tang@gmail.com> Co-authored-by: abisalehalliprasan <38014312+abisalehalliprasan@users.noreply.github.com> * Release : 2.1.0 * Release : 2.1.0 * Release : 2.1.0 : Revert back dependencies * Release : 2.1.0 : Revert back dependencies Co-authored-by: Zina Schroeder <zina.schroeder@gmail.com> Co-authored-by: Sébastien Boulle <sebastien@cleany.fr> Co-authored-by: Oscar Rabasa <oscargrp@gmail.com> Co-authored-by: Kevin Tang <kevin.hm.tang@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed as I was using this package that the Intuit Payment API in particular doesn't always respond with 200 status codes. Currently, this package is written to only consider 200 codes successful, so to prevent my code from breaking, I needed the client to accept any status that would normally count as a "success" as valid. I've modified the single line validity check to accept anything within the 2XX range.