Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds renovate configuration to repo - hacktoberfest #78

Merged
merged 7 commits into from
Oct 23, 2020

Conversation

joshharrison626
Copy link
Contributor

@joshharrison626 joshharrison626 commented Oct 13, 2020

Hacktoberfest Title

Adds renovate configuration to repo.

Description of what's changing

Uses much of the methods described in this document (https://docs.google.com/document/d/1aJ3eIpX65tgyIwPL1Pympm0Qsz-phhXVfT5RhAmXM_M/edit#) and sets up the repo to use renovate to manage dependencies.
This suggested configuration will

  1. Group PR's into two groups, Major and Minor/Patch
  2. It will NOT auto-merge (but you can change this at anytime by setting automerge to true
  3. Allows Renovate to manage ALL dependencies
  4. Uses the chore commit type

What else might be impacted?

No other impact; however, this PR will not actually take affect until you merge this PR and then add the repo to the Renovate service (https://github.intuit.com/github-apps/renovate-pro/). Once both are done, you will start seeing PR's being generated by Renovate. They will not be merged automatically, and they will be in two groups to help make it easier to manage the dependency PRs: Major, and Minor/Patch.

Which issue does this PR relate to?

#26

Checklist

[x] Tests are written and maintain or improve code coverage - N/A
[x] I've tested this in my application using yarn link (if applicable) - N/A
[x] You consent to and are confident this change can be released with no regression - N/A

@joshharrison626 joshharrison626 changed the title Adds renovate configuration to repo Adds renovate configuration to repo - hacktoberfest Oct 13, 2020
README.md Outdated Show resolved Hide resolved
Co-authored-by: Susmitha Kodamarthi <f2004156@gmail.com>
@skodamarthi
Copy link
Contributor

@joshharrison626 Not sure why the PR build is failing. We saw this issue with another PR as well but do not exactly know the root cause yet. #74. Do you have any idea what could be the issue?

@reubenae
Copy link
Contributor

I don't see why the CI job is failing on this PR. @skodamarthi any ideas? Can we just go ahead and merge this anyway?

@joshharrison626
Copy link
Contributor Author

Sorry I don't have access to circle-ci to help troubleshoot the test failures.

@reubenae
Copy link
Contributor

No worries @joshharrison626 - this definitely isn't an issue with your PR. We're working to fix the CI issue and I am confident merge this PR before hacktoberfest ends

@tylerkrupicka tylerkrupicka mentioned this pull request Oct 19, 2020
@joshharrison626
Copy link
Contributor Author

Just wanted to check in and see if there was anything you need from me for this PR. Thanks!

@skodamarthi
Copy link
Contributor

Thanks @joshharrison626.. merging this PR now. I and @reubenae will do the configuration changes on Renovate to add our repo sometime next week. We will get back to you if we have any questions.

@skodamarthi skodamarthi merged commit f841541 into intuit:master Oct 23, 2020
@joshharrison626
Copy link
Contributor Author

Very cool, and yes, I'm happy to help finish the renovate setup if you need help.

@joshharrison626
Copy link
Contributor Author

Could you please add the hacktoberfest-accepted label to this PR?

@reubenae
Copy link
Contributor

@joshharrison626 done, though we've registered this repo for hacktoberfest so it shouldn't be required for it to show up in your stats. Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants