Preaudit changes #305
Merged
Preaudit changes #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wojciech-cichocki
requested changes
Oct 9, 2024
| @@ -19,6 +19,7 @@ scale-info = { version = "2.11.3", default-features = false } | |||
| [dev-dependencies] | |||
| ink_e2e = "5.0.0" | |||
| test_helpers = { path = "src/test_helpers", default-features = false } | |||
| scale-info = "2.11.3" | |||
There was a problem hiding this comment.
what's the reason for adding this dev-dependencies?
There was a problem hiding this comment.
rust-analyzer gets fussy without it for me locally, my bad will remove
wojciech-cichocki
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
+ rename
InvariantTraittoInvariantEntrypoints+ split
routeintorouteandroute_mutto makequote_routetake an immutable reference+
get_positionandget_positionstake an immutable reference+ require passing the correct address to
withdraw_all_wazero(5CtuFVgEUz13SFPVY6s2cZrnLDEkxQXc19aXrNARwEBeCXgg) source+ add
devfeature that removes the requirement of passing mainnet'swithdraw_all_wazeroaddress