Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add max liquidity slider #386

Draft
wants to merge 6 commits into
base: dev
Choose a base branch
from
Draft

add max liquidity slider #386

wants to merge 6 commits into from

Conversation

zielvna
Copy link
Collaborator

@zielvna zielvna commented Jan 16, 2025

No description provided.

wojciech-cichocki
wojciech-cichocki requested changes Jan 17, 2025
View reviewed changes
Copy link
Member

@wojciech-cichocki wojciech-cichocki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Set the fill level only to green (at 46% here)

image

wojciech-cichocki
wojciech-cichocki requested changes Jan 17, 2025
View reviewed changes
Copy link
Member

@wojciech-cichocki wojciech-cichocki left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disable these inputs in the same way as single-token assets, but without text:
image

To:
image

wojciech-cichocki
wojciech-cichocki requested changes Jan 17, 2025
View reviewed changes
Copy link
Member

@wojciech-cichocki wojciech-cichocki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works incorrectly in rage mode because there is a negative value:
image

wojciech-cichocki
wojciech-cichocki requested changes Jan 17, 2025
View reviewed changes
Copy link
Member

@wojciech-cichocki wojciech-cichocki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should change this text to: Custom amounts form Use all funds
image

wojciech-cichocki
wojciech-cichocki requested changes Jan 17, 2025
View reviewed changes
Copy link
Member

@wojciech-cichocki wojciech-cichocki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be more vibe disabled to this slider:
image

@p6te
Copy link
Contributor

p6te commented Jan 17, 2025

without wallet connected it shows negative values on concentration mode.
maybe its better to hide this feature when wallet is not connected?
image

@github-actions GitHub Actions
Copy link

This pull request has been deployed to Vercel.

Latest commit: 7e7a9ca
✅ Preview: https://webapp-eclipse-mrr086k0x-invariantlabs.vercel.app
🔍 Inspect: https://vercel.com/invariantlabs/webapp-eclipse/Fmg86FSYGoCzds1vX93Nfpinxy2C

View Workflow Logs

@wojciech-cichocki wojciech-cichocki marked this pull request as draft February 5, 2025 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wojciech-cichocki wojciech-cichocki wojciech-cichocki requested changes

@p6te p6te p6te approved these changes

Assignees
No one assigned
Labels
deployed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zielvna @p6te @wojciech-cichocki @Sniezka1927