-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compat AWSS3 0.7 and 0.8 #11
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regarding why CI is failing, I'm guessing it's because aws_config()
is failing and that's being called by tryparse
. I think the solution will be to use nothing
as the default and exit earlier than any aws_config
migth need to be used. I can make that change and probably backport in on AWSS3.jl
Codecov Report
@@ Coverage Diff @@
## main #11 +/- ##
==========================================
- Coverage 92.68% 91.04% -1.64%
==========================================
Files 3 3
Lines 82 67 -15
==========================================
- Hits 76 61 -15
Misses 6 6
Continue to review full report at Codecov.
|
Backport for |
Co-authored-by: Rory Finnegan <rory.finnegan@gmail.com>
Adding compat for AWSS3 0.7. This required a change in one function for compatibility.