Compat AWSS3 0.7 and 0.8 #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rofinn
reviewed
Feb 8, 2021
There was a problem hiding this comment.
Regarding why CI is failing, I'm guessing it's because aws_config() is failing and that's being called by tryparse. I think the solution will be to use nothing as the default and exit earlier than any aws_config migth need to be used. I can make that change and probably backport in on AWSS3.jl
Codecov Report
@@ Coverage Diff @@
## main #11 +/- ##
==========================================
- Coverage 92.68% 91.04% -1.64%
==========================================
Files 3 3
Lines 82 67 -15
==========================================
- Hits 76 61 -15
Misses 6 6
Continue to review full report at Codecov.
|
|
Backport for |
Co-authored-by: Rory Finnegan <rory.finnegan@gmail.com>
This was referenced Feb 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding compat for AWSS3 0.7. This required a change in one function for compatibility.