Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loosen DataStructure compat versions #13

Merged
merged 2 commits into from
Feb 15, 2021
Merged

Conversation

rofinn
Copy link
Member

@rofinn rofinn commented Feb 15, 2021

No description provided.

@codecov
Copy link

codecov bot commented Feb 15, 2021

Codecov Report

Merging #13 (d7ebff1) into main (cdb02ad) will increase coverage by 0.86%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #13      +/-   ##
==========================================
+ Coverage   92.68%   93.54%   +0.86%     
==========================================
  Files           3        3              
  Lines          82       62      -20     
==========================================
- Hits           76       58      -18     
+ Misses          6        4       -2     
Impacted Files Coverage Δ
src/session.jl 100.00% <0.00%> (ø)
src/Checkpoints.jl 88.88% <0.00%> (+0.42%) ⬆️
src/handler.jl 90.90% <0.00%> (+1.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cdb02ad...822275b. Read the comment docs.

@rofinn
Copy link
Member Author

rofinn commented Feb 15, 2021

AFAICT, DefaultDict wasn't changed during that major release. Ran the tests locally with it pinned to 0.17.20 it still passed.

@rofinn rofinn merged commit a217d11 into main Feb 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants