deprecate old checkpointing syntax #17
Conversation
Codecov Report
@@ Coverage Diff @@
## main #17 +/- ##
==========================================
+ Coverage 93.90% 95.09% +1.19%
==========================================
Files 3 4 +1
Lines 82 102 +20
==========================================
+ Hits 77 97 +20
Misses 5 5
Continue to review full report at Codecov.
|
src/deprecated.jl
Outdated
| @@ -0,0 +1,10 @@ | |||
| function checkpoint_deprecation() | |||
There was a problem hiding this comment.
If we did
| function checkpoint_deprecation() | |
| function checkpoint_deprecation(tags...) |
then we we can move the isempty here.
and can print the alternative.
| @testset "deprecated tags syntax" begin | ||
| mktempdir() do path | ||
| Checkpoints.config("TestPkg.deprecated", path) | ||
| TestPkg.deprecated_checkpoint_syntax() |
There was a problem hiding this comment.
I think you can use @test_deprecated to check this, and also maybe surpress the warning.
I haven't tried yet
| TestPkg.deprecated_checkpoint_syntax() | |
| @test_deprecated TestPkg.deprecated_checkpoint_syntax() |
There was a problem hiding this comment.
just need to address https://github.com/invenia/Checkpoints.jl/pull/17/files#r629495939
and this is good to go
follow up to #15