Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and test ArgumentError for nonexistant dir #36

Merged
merged 2 commits into from
Oct 13, 2021

Conversation

bencottier
Copy link
Contributor

@bencottier bencottier commented Oct 13, 2021

Following #34, The ArgumentError call was not valid, and there was no test for the case where the ArgumentError happens.

@codecov
Copy link

codecov bot commented Oct 13, 2021

Codecov Report

Merging #36 (21cde53) into main (9e0b661) will decrease coverage by 0.51%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #36      +/-   ##
==========================================
- Coverage   95.51%   95.00%   -0.52%     
==========================================
  Files           5        5              
  Lines         156      140      -16     
==========================================
- Hits          149      133      -16     
  Misses          7        7              
Impacted Files Coverage Δ
src/indexing.jl 91.89% <100.00%> (-0.42%) ⬇️
src/Checkpoints.jl 91.66% <0.00%> (-1.36%) ⬇️
src/handler.jl 96.77% <0.00%> (-0.20%) ⬇️
src/session.jl 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e0b661...21cde53. Read the comment docs.

@bencottier bencottier merged commit 72299dd into main Oct 13, 2021
@bencottier bencottier deleted the bc/argument-error-fix branch October 13, 2021 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants