Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround for indexing S3Path with "." relpath #42

Merged
merged 3 commits into from
Dec 9, 2021
Merged

Conversation

bencottier
Copy link
Contributor

Closes #41

@codecov
Copy link

codecov bot commented Dec 9, 2021

Codecov Report

Merging #42 (4dfe6bc) into main (e2ded1d) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #42      +/-   ##
==========================================
- Coverage   96.12%   96.10%   -0.03%     
==========================================
  Files           5        5              
  Lines         155      154       -1     
==========================================
- Hits          149      148       -1     
  Misses          6        6              
Impacted Files Coverage Δ
src/indexing.jl 95.12% <100.00%> (+0.38%) ⬆️
src/Checkpoints.jl 92.68% <0.00%> (-0.35%) ⬇️
src/handler.jl 96.87% <0.00%> (-0.10%) ⬇️
src/session.jl 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2ded1d...4dfe6bc. Read the comment docs.

Copy link
Member

@oxinabox oxinabox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not fix this in AWSS3.jl?
Isn't it a super simple change?
Whereas this workaround is tech debg we have to remember to come back and remove.
I won't block this PR over it though.

@bencottier
Copy link
Contributor Author

bencottier commented Dec 9, 2021

Why not fix this in AWSS3.jl? Isn't it a super simple change? Whereas this workaround is tech debg we have to remember to come back and remove. I won't block this PR over it though.

It might be a simple change but I still don't know what the change should be. (I don't have enough "theory" yet of AWSS3/FilePathsBase to make the right change)

There are some rough suggestions here:

@bencottier bencottier merged commit 8c25fea into main Dec 9, 2021
@oxinabox oxinabox deleted the bc/s3-relpath branch December 9, 2021 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error indexing S3Path with JLSO file at top level
2 participants