Handle millisecond timestamps on 32-bit #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #16 +/- ##
=======================================
Coverage 96.59% 96.59%
=======================================
Files 5 5
Lines 147 147
=======================================
Hits 142 142
Misses 5 5
Continue to review full report at Codecov.
|
omus
reviewed
Oct 11, 2019
| @@ -1,5 +1,5 @@ | |||
| using Mocking | |||
| Mocking.enable(; force=true) | |||
| Mocking.activate() | |||
There was a problem hiding this comment.
FYI with Mocking 0.7 you can put Mocking.activate() anywhere before you use a patch. Usually I place this after all the package imports
omus
approved these changes
Oct 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intis too small on 32-bit to store millisecond timestamps. Other uses ofIntshould be fine.Fixes #15