Add Memento v1 #23
Add Memento v1 #23
Conversation
Codecov Report
@@ Coverage Diff @@
## master #23 +/- ##
=======================================
Coverage 93.58% 93.58%
=======================================
Files 5 5
Lines 156 156
=======================================
Hits 146 146
Misses 10 10
Continue to review full report at Codecov.
|
| @@ -1,6 +1,6 @@ | |||
| # Do not share a stream between processes | |||
| # The token would be shared so putting would give InvalidSequenceTokenException a lot | |||
| struct CloudWatchLogHandler{F<:Formatter} <: Handler{F, Union{}} | |||
There was a problem hiding this comment.
This was throwing LoadError: LoadError: too many parameters for type
There was a problem hiding this comment.
This changed between Memento 0.12 and 0.13. If you want to support both, you'll need to make this conditional. I would just drop Memento 0.12.
| @@ -1,6 +1,6 @@ | |||
| # Do not share a stream between processes | |||
| # The token would be shared so putting would give InvalidSequenceTokenException a lot | |||
| struct CloudWatchLogHandler{F<:Formatter} <: Handler{F, Union{}} | |||
There was a problem hiding this comment.
This changed between Memento 0.12 and 0.13. If you want to support both, you'll need to make this conditional. I would just drop Memento 0.12.
Co-Authored-By: Eric Davies <iamed2@gmail.com>
No description provided.