-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Memento v1 #23
Add Memento v1 #23
Conversation
Codecov Report
@@ Coverage Diff @@
## master #23 +/- ##
=======================================
Coverage 93.58% 93.58%
=======================================
Files 5 5
Lines 156 156
=======================================
Hits 146 146
Misses 10 10
Continue to review full report at Codecov.
|
@@ -1,6 +1,6 @@ | |||
# Do not share a stream between processes | |||
# The token would be shared so putting would give InvalidSequenceTokenException a lot | |||
struct CloudWatchLogHandler{F<:Formatter} <: Handler{F, Union{}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was throwing LoadError: LoadError: too many parameters for type
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This changed between Memento 0.12 and 0.13. If you want to support both, you'll need to make this conditional. I would just drop Memento 0.12.
@@ -1,6 +1,6 @@ | |||
# Do not share a stream between processes | |||
# The token would be shared so putting would give InvalidSequenceTokenException a lot | |||
struct CloudWatchLogHandler{F<:Formatter} <: Handler{F, Union{}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This changed between Memento 0.12 and 0.13. If you want to support both, you'll need to make this conditional. I would just drop Memento 0.12.
Co-Authored-By: Eric Davies <iamed2@gmail.com>
No description provided.