Extend Branch definition to include transformers #6
Conversation
Codecov Report
@@ Coverage Diff @@
## main #6 +/- ##
==========================================
+ Coverage 75.26% 79.59% +4.32%
==========================================
Files 2 2
Lines 93 98 +5
==========================================
+ Hits 70 78 +8
+ Misses 23 20 -3
Continue to review full report at Codecov.
|
src/system.jl
Outdated
| @@ -99,6 +99,60 @@ struct Branch | |||
| break_points::Tuple{Float64, Float64} | |||
| "Price penalties for each of the break points of the branch (\$)" | |||
| penalties::Tuple{Float64, Float64} | |||
| "Resistance of the transformer (Ohm)" | |||
| resistance::Float64 | |||
| "Reactance of the transformer or branch (Ohm)" | |||
There was a problem hiding this comment.
What do we want the units of Resistance and Reactance to be?
There was a problem hiding this comment.
As mentioned in the discussion we had in the FNDP PR, I think having all branch parameters in pu is the best course unfortunately. It just makes everything much simpler, otherwise we'd need to rely on conversions whenever doing operations with parameters from different branches.
There was a problem hiding this comment.
Should rate_a and rate_b also be in pu? Or are they ok in MVA.
There was a problem hiding this comment.
I think for the sake of simplicity we can postpone the pu discussion to later when we already have things figured out. Let's just keep everything as pu for now. For things that are in MW/MVA, we can either rely on base_power being stored somewhere or document that we assume base = 100 MW.
src/system.jl
Outdated
| "Resistance of the transformer (pu)" | ||
| resistance::Float64 | ||
| "Reactance of the transformer or branch (pu)" | ||
| reactance::Float64 |
There was a problem hiding this comment.
Given that transformer is a subset of branch, I'd just say "branch" here – "transformer or branch" is confusing
I'd also say branch for the resistance as it makes sense for lines to have resistance even though we don't use it in the formulation or to compute shift factors
|
LGTM |
No description provided.