Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compat for Julia 0.7 #68

Merged
merged 4 commits into from
May 22, 2018
Merged

Compat for Julia 0.7 #68

merged 4 commits into from
May 22, 2018

Conversation

iamed2
Copy link
Member

@iamed2 iamed2 commented Apr 25, 2018

No description provided.

@rofinn
Copy link
Member

rofinn commented May 15, 2018

Depends on Compat#545 getting through.

ararslan
ararslan reviewed May 18, 2018
View reviewed changes
src/Memento.jl Outdated
@@ -3,6 +3,7 @@ __precompile__()
module Memento

using Base: StackTrace, StackFrame
using Sockets
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be Compat.Sockets

@ararslan
Copy link
Contributor

Once JuliaLang/Compat.jl#548 is merged and Compat 0.65.0 is tagged, REQUIRE here should be updated to Compat 0.65.0.

@codecov
Copy link

codecov bot commented May 19, 2018 •
edited
Loading

Codecov Report

Merging #68 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #68   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           9      9           
  Lines         251    251           
=====================================
  Hits          251    251
Impacted Files Coverage Δ
src/loggers.jl 100% <ø> (ø) ⬆️
src/Memento.jl 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update edb5d72...f93bc64. Read the comment docs.

@ararslan
Copy link
Contributor

The test failures here on 0.7 should be fixed once Syslogs is tagged.

@rofinn
Copy link
Member

rofinn commented May 19, 2018

JuliaLang/METADATA.jl#14721

@ararslan ararslan closed this May 19, 2018
@ararslan ararslan reopened this May 19, 2018
@rofinn
Copy link
Member

rofinn commented May 19, 2018

Should we bump up the Syslogs version?

@ararslan
Copy link
Contributor

It shouldn't be necessary since there have been no API changes in Syslogs since its previous release. Version resolution will already pick the latest version of Syslogs when installing Memento and/or updating packages.

@ararslan
Copy link
Contributor

Btw it looks like we might need some @everywhere usings in the concurrent logging tests here to fix some more deprecation warnings but I've not experimented with that yet.

@rofinn
Copy link
Member

rofinn commented May 22, 2018

Alright, this looks good to me. We'll want to do another round of cleanup once 0.7 is released anyways.

@rofinn rofinn merged commit c9305de into master May 22, 2018
@rofinn rofinn mentioned this pull request May 22, 2018
Closed
@iamed2 iamed2 deleted the ed/compatagain branch May 22, 2018 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ararslan ararslan ararslan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iamed2 @rofinn @ararslan