Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong Doku (typo)? #22

Open
mlechner opened this issue Oct 17, 2016 · 2 comments
Open

Wrong Doku (typo)? #22

mlechner opened this issue Oct 17, 2016 · 2 comments

Comments

@mlechner
Copy link

Hi, when i try to follow the example on http://flask-sso.readthedocs.io/en/latest/#a-minimal-example I get the following error:

@sso.login_handler
NameError: name 'sso' is not defined

As described in the docs i defined

app = Flask(__name__)
...
ext = SSO(app=app)

Shouldn't it be
sso = SSO(app=app)
or
@ext.login_handler

@jirikuncar
Copy link
Member

@mlechner thanks for spotting it! I propose:

-ext = SSO(app=app)
+sso = SSO(app=app)

@millergd
Copy link

FYI docs still not updated to reflect this. I had a few minutes of panic/scrambling before realizing this

jirikuncar added a commit that referenced this issue May 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants