link creator's name to search #855
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ines-cruz
force-pushed
the
linkpillssearch
branch
2 times, most recently
from
1d70ebf to
f93c682
Compare
ines-cruz
force-pushed
the
linkpillssearch
branch
from
f93c682 to
2419235
Compare
|
part of the task ( the linking the subjects) will be done in this task: #856 |
|
could you add screenshot of how the UI looks like? (different sizes 👼 ) |
|
Sorry, here are the changes, i just added the link to the name of the author, you can see the link in the bottom of the page when you hover over a name and then the other photo is the search page after we click on the name |
lnielsen
reviewed
May 26, 2021
| class="ui tooltip-popup text-muted" | ||
| {% if show_affiliations and creatibutor.affiliations %} | ||
| data-content="{{ creatibutor.affiliations|join('; ', attribute='1') }}" | ||
| {% endif %} | ||
| href="/search?q=metadata.creators.person_or_org.name{{ creatibutor.person_or_org.name}}" |
There was a problem hiding this comment.
Suggested change
| href="/search?q=metadata.creators.person_or_org.name{{ creatibutor.person_or_org.name}}" | |
| href="{{ url_for('invenio_search_ui.search', q='metadata.creators.person_or_org.name:" creatibutor.person_or_org.name") }}" |
Can you check that the following would work:
- Deposit a record with both a person and an organistaion.
- Make sure both of them have spaces in their name and the names are unique to all other records.
- Once deposited, you should be able to click the name, and get a hit (and only one hit) in the search result.
|
closed in favor of #858 |
fenekku
added a commit
to fenekku/invenio-app-rdm
that referenced
this pull request
May 7, 2024
fenekku
added a commit
to fenekku/invenio-app-rdm
that referenced
this pull request
May 7, 2024
fenekku
added a commit
to fenekku/invenio-app-rdm
that referenced
this pull request
May 7, 2024
fenekku
added a commit
to fenekku/invenio-app-rdm
that referenced
this pull request
Jul 9, 2024
fenekku
added a commit
to fenekku/invenio-app-rdm
that referenced
this pull request
Jul 9, 2024
fenekku
added a commit
to fenekku/invenio-app-rdm
that referenced
this pull request
Jul 19, 2024
…y-membership-request discussion page - add necessary template variable - add style - generalize header macro membership-requests [inveniosoftware#855]: waiting flow: dashboard
fenekku
added a commit
to fenekku/invenio-app-rdm
that referenced
this pull request
Jul 26, 2024
fenekku
added a commit
to fenekku/invenio-app-rdm
that referenced
this pull request
Jul 29, 2024
…munity dashboard [+] - also fix top menu to display "Members"
fenekku
added a commit
to fenekku/invenio-app-rdm
that referenced
this pull request
Jul 30, 2024
…y-membership-request discussion page - add necessary template variable - add style - generalize header macro membership-requests [inveniosoftware#855]: waiting flow: dashboard
fenekku
added a commit
to fenekku/invenio-app-rdm
that referenced
this pull request
Jul 30, 2024
fenekku
added a commit
to fenekku/invenio-app-rdm
that referenced
this pull request
Jul 30, 2024
…munity dashboard [+] - also fix top menu to display "Members"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.