api: add missing transition conditions #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jma
force-pushed
the
jma-#28-extend-conditions
branch
3 times, most recently
from
41fe491 to
8860880
Compare
zzacharo
approved these changes
Jul 20, 2018
invenio_circulation/utils.py
Outdated
| # 30 days by default | ||
| if not end_date: | ||
| end_date = datetime.strptime(start_date, '%Y-%m-%d') + timedelta( | ||
| days=30 |
There was a problem hiding this comment.
Is it worth to make the 30 days by default in a config variable for quick overridability?
invenio_circulation/utils.py
Outdated
| end_date = start_date + timedelta(days=30) | ||
| return (start_date.strftime('%Y-%m-%d'), end_date.strftime('%Y-%m-%d')) | ||
| end_date = datetime.strptime(transaction_date, '%Y-%m-%d') + timedelta( | ||
| days=30 |
jma
force-pushed
the
jma-#28-extend-conditions
branch
from
8860880 to
db1ded3
Compare
* Implement checkin, request, validate_request circulation policies using states conditions. (closes inveniosoftware#28) Signed-off-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
jma
force-pushed
the
jma-#28-extend-conditions
branch
from
db1ded3 to
534d3fb
Compare
|
@jma can you rebase with the latest master and push again? So we can merge it after? There are some changes to be done as states and transitions are moved to the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
using states conditions. (closes [TASK-US#23] extend conditions to all actions #28)
Signed-off-by: Johnny Mariéthoz Johnny.Mariethoz@rero.ch