review police: allow all community members to submit records to commu…

…nity without review

* closes CERNDocumentServer/cds-rdm#176

invenio_communities/assets/semantic-ui/js/invenio_communities/settings/pages/index.js

@@ -3,10 +3,6 @@ import ReactDOM from "react-dom";
 import React from "react";
 
 const domContainer = document.getElementById("community-settings-pages");
-const formConfig = JSON.parse(domContainer.dataset.formConfig);
 const community = JSON.parse(domContainer.dataset.community);
 
-ReactDOM.render(
-  <CommunityPagesForm formConfig={formConfig} community={community} />,
-  domContainer
-);
+ReactDOM.render(<CommunityPagesForm community={community} />, domContainer);

invenio_communities/communities/records/jsonschemas/communities/communities-v1.0.0.json

@@ -47,7 +47,8 @@
           "description": "Community review policy.",
           "enum": [
             "open",
-            "closed"
+            "closed",
+            "members"
           ]
         }
       }

invenio_communities/communities/records/systemfields/access.py

@@ -70,6 +70,8 @@ class ReviewPolicyEnum(AccessEnumMixin, Enum):
 
     CLOSED = "closed"
 
+    MEMBERS = "members"
+
 
 class CommunityAccess:
     """Access management per community."""

invenio_communities/communities/schema.py

@@ -117,6 +117,7 @@ class CommunityAccessSchema(Schema):
             [
                 "open",
                 "closed",
+                "members",
             ]
         )
     )

invenio_communities/generators.py

@@ -18,6 +18,7 @@
 
 from flask_principal import UserNeed
 from invenio_access.permissions import any_user, authenticated_user, system_process
+from invenio_records.dictutils import dict_lookup
 from invenio_records_permissions.generators import Generator
 from invenio_search.engine import dsl
 
@@ -125,11 +126,40 @@ def __init__(self, field, then_, else_):
         )
 
 
-class IfPolicyClosed(IfRestrictedBase):
+class ReviewPolicy(Generator):
     """If policy is closed."""
 
-    def __init__(self, field, then_, else_):
+    def __init__(self, closed_, open_, members_):
+        """Constructor."""
+        self.closed_ = closed_
+        self.open_ = open_
+        self.members_ = members_
+
+    def _generators(self, record, **kwargs):
+        """Get the generators."""
+        review_policy = dict_lookup(record, "access.review_policy")
+
+        if review_policy == "closed":
+            return self.closed_
+        elif review_policy == "open":
+            return self.open_
+        elif review_policy == "members":
+            return self.members_
+
+    def needs(self, record=None, **kwargs):
+        """Set of Needs granting permission."""
+        needs = [
+            g.needs(record=record, **kwargs) for g in self._generators(record, **kwargs)
+        ]
+        return set(chain.from_iterable(needs))
+
+
+class IfRecordPolicyClosed(IfRestrictedBase):
+    """If record policy is closed."""
+
+    def __init__(self, then_, else_):
         """Initialize."""
+        field = "record_policy"
         super().__init__(
             lambda r: (
                 getattr(r.access, field, None)

invenio_communities/permissions.py

@@ -33,8 +33,9 @@
     CommunityOwners,
     CommunitySelfMember,
     IfCommunityDeleted,
-    IfPolicyClosed,
+    IfRecordPolicyClosed,
     IfRestricted,
+    ReviewPolicy,
 )
 
 
@@ -82,8 +83,7 @@ class CommunityPermissionPolicy(BasePermissionPolicy):
     can_rename = [CommunityOwners(), SystemProcess()]
 
     can_submit_record = [
-        IfPolicyClosed(
-            "record_policy",
+        IfRecordPolicyClosed(
             then_=[CommunityMembers(), SystemProcess()],
             else_=[
                 IfRestricted(
@@ -97,11 +97,11 @@ class CommunityPermissionPolicy(BasePermissionPolicy):
 
     # who can include a record directly, without a review
     can_include_directly = [
-        IfPolicyClosed(
-            "review_policy",
-            then_=[Disable()],
-            else_=[CommunityCurators()],
-        ),
+        ReviewPolicy(
+            closed_=[Disable()],
+            open_=[CommunityCurators()],
+            members_=[CommunityMembers()],
+        )
     ]
 
     can_members_add = [

invenio_communities/templates/semantic-ui/invenio_communities/details/settings/pages.html

@@ -21,7 +21,6 @@
   <div
     id="community-settings-pages"
     data-community='{{ community | tojson }}'
-    data-form-config='{{ form_config | tojson }}'
   >
   </div>
 {%- endblock settings_body %}

invenio_communities/views/communities.py

@@ -80,6 +80,14 @@
             "Submissions to the community by default requires review, but curators, managers and owners can publish directly without review."
         ),
     },
+    {
+        "text": "Allow all members to publish without review",
+        "value": "members",
+        "icon": "lock open",
+        "helpText": _(
+            "Submissions to the community by default requires review, but all community members can publish directly without review."
+        ),
+    },
 ]
 
 
@@ -412,9 +420,6 @@ def communities_settings_pages(pid_value, community, community_ui):
         theme=community_ui.get("theme", {}),
         community=community_ui,
         permissions=permissions,
-        form_config=dict(
-            access=dict(review_policy=REVIEW_POLICY_FIELDS),
-        ),
     )