user_moderation: user search for fetching user communities #1204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Uses search results to determine a blocked/restored user's communities. * Uses TaskOp and Unit of Work for sending off action tasks.
jrcastro2
reviewed
Sep 9, 2024
Comment on lines
+29
to
+42
| if from_db: | ||
| query = db.session.query(mem_model_cls.community_id).filter( | ||
| mem_model_cls.user_id == user_id, | ||
| mem_model_cls.role == "owner", | ||
| ) | ||
| return (row[0] for row in query.yield_per(1000)) | ||
| else: | ||
| search = ( | ||
| RecordsSearchV2(index=mem_cls.index._name) | ||
| .filter("term", user_id=user_id) | ||
| .filter("term", role="owner") | ||
| .source(["community_id"]) | ||
| ) | ||
| return (hit["community_id"] for hit in search.scan()) |
There was a problem hiding this comment.
Major: Hmm I think we are missing the filtering for the communities that are owned solely by the user, unless I am missing something?
There was a problem hiding this comment.
You're right, this doesn't check anymore if the user is the only owner. Part of the change was to improve on the overall performance (before there was some in-memory overfetching). I think adding the check back is not that big of a performance hit, so I'll have a go at it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
communities.