Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes es6 (es5 and es2). #12

Closed
wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented May 16, 2022

@ghost ghost force-pushed the feature-remove-es6 branch from 75b598a to 67c3ce3 Compare May 17, 2022 13:59
@ghost ghost changed the title [DRAFT] Removes es6 (es5 and es2). Removes es6 (es5 and es2). May 17, 2022
@utnapischtim utnapischtim requested review from slint and ntarocco and removed request for slint March 27, 2023 13:33
@slint
Copy link
Member

slint commented Mar 28, 2023

Unfortunately, this is a very "old" module that didn't receive any love in terms of modernizing to use docker-services-cli and other best practices for GitHub CI.

On the other hand, it's also a very "special" module, since it's also testing e.g. cross-cluster migration of indices, so I'm not even sure if we could test it using our usual methods.

@chriz-uniba are you using this module actively for migrating indices? It's pretty rough on the edges still since it was originally developed as a common solution between some of our Invenio instances at CERN to help with migrating/upgrading our search clusters with minimal downtime. Eventually it might be used for InenioRDM to perform mapping upgrades across versions, but it's very early to tell.

@ghost
Copy link
Author

ghost commented Mar 29, 2023

there was an open issue wrt. elasticsearch and I worked on it in every https://github.com/inveniosoftware/ I could find references to old elasticsearches. Feel free to close or ignore. ;)

@slint
Copy link
Member

slint commented Apr 17, 2023

Thanks for the explanation, I'm closing it then :)

@slint slint closed this Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Released | Done 🚀
Development

Successfully merging this pull request may close these issues.

1 participant