Add filename of attachment #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntarocco
reviewed
Jan 14, 2025
Comment on lines
+86
to
+88
| filename = None | ||
| if "filename" in attachment: | ||
| filename = attachment.get("filename") |
There was a problem hiding this comment.
Is None an accepted value by msg.attach for the filename?
Suggested change
| filename = None | |
| if "filename" in attachment: | |
| filename = attachment.get("filename") | |
| filename = attachment.get("filename") |
There was a problem hiding this comment.
Yes, None is accepted. But if you just call attachment.get("filename") and the key doesn't exist a KeyError will be raised.
slint
added a commit
to zenodo/zenodo-rdm
that referenced
this pull request
Feb 7, 2025
📁 invenio-administration (3.0.0 -> 3.1.0 🌈)
release: v3.1.0
modal: add support for custom modal SUI props
📁 invenio-mail (2.2.0 -> 2.2.1 🐛)
release: v2.2.1
upgrade CI
Add filename of attachments (inveniosoftware/invenio-mail#68)
📁 invenio-oauth2server (3.0.0 -> 3.0.2 🐛)
📦 release: v3.0.2
refactor: copy code from flask-oauthlib-invenio
* the problem is that request.form triggers parsing the form. parsing
the form triggers checking the max_content_length. if a file greater
then the allowed filesize is uploaded this raises the
RequestEntityTooLarge exception
* to verify the request the body is not used, the token is used for
verification
release: v3.0.1
fix: update iter_choices to include additional parameter in SelectSUI
📁 invenio-records-resources (7.0.0 -> 7.0.1 🐛)
📦 release: v7.0.1
fix: file upload >100MB
* flask uses now the MAX_CONTENT_LENGTH to restrict file upload. it is
possible to set the max_content_length per request. so for this request
it is set to the configured max file size
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❤️ Thank you for your contribution!
Description
Currently there is no possibility to set the name of an attachment. This PR will add the possibility.
Checklist
Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:
Frontend
Reminder
By using GitHub, you have already agreed to the GitHub’s Terms of Service including that: