Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

notifications: add submission action notifications #1447

Merged

Conversation

rekt-hard
Copy link
Contributor

@rekt-hard rekt-hard commented Sep 6, 2023

actions: send notification on submission accept action

❤️ Thank you for your contribution!

Description

closes inveniosoftware/invenio-requests#339
Send notification when executing a submission request action.

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Third-party code

If you've added third-party code (copy/pasted or new dependencies), please reach out to an architect.

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.

@rekt-hard
Copy link
Contributor Author

rekt-hard commented Sep 6, 2023

Specific accept action notification for the community submission. Other actions will follow a similar pattern.
I think accept/decline would be the same.
Expire should probably only notify the request creator. Since the action will be performed by the system, we probably do not need the identity and the identity context resolve.
For cancel, it should probably notify the community owners/curators (similar to the community submission).

@rekt-hard rekt-hard force-pushed the request-action-notifications branch from 745a1ad to aa47b12 Compare September 7, 2023 07:55
@rekt-hard rekt-hard force-pushed the request-action-notifications branch from aa47b12 to bddb076 Compare September 8, 2023 13:58
@kpsherva
Copy link
Contributor

kpsherva commented Sep 8, 2023

if we merge this PR we will send 2 emails for access request accept action, see:
https://github.com/inveniosoftware/invenio-rdm-records/blob/master/invenio_rdm_records/requests/access/requests.py#L104
could you integrate (replace) this one with your newly defined actions notifications ?

@rekt-hard rekt-hard changed the title notifications: add submission accept action notification notifications: add submission action notifications Sep 8, 2023
@rekt-hard rekt-hard force-pushed the request-action-notifications branch from bddb076 to 2c0199f Compare September 8, 2023 14:24
@rekt-hard
Copy link
Contributor Author

These notifications are specific to the community submission/inclusion actions. Do access requests and inclusion requests share the same service? If not, we should be good here.
Should we create a separate PR for replacing the mails with notifications?

@kpsherva
Copy link
Contributor

kpsherva commented Sep 8, 2023

These notifications are specific to the community submission/inclusion actions. Do access requests and inclusion requests share the same service? If not, we should be good here. Should we create a separate PR for replacing the mails with notifications?

OK for separate PR!

@rekt-hard
Copy link
Contributor Author

Just tested locally and it did not send two mails/notifications on access request accept action.

actions: send notification on submission accept action
@kpsherva kpsherva force-pushed the request-action-notifications branch from 2c0199f to cbede2c Compare October 2, 2023 11:28
@zzacharo zzacharo merged commit 13d70c9 into inveniosoftware:master Oct 2, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notifications: send notif on actions
3 participants